test: use RTL in the version selector tests

Author: erikian

Diff for: rtl-spec/components/commands-version-chooser.spec.tsx

@@ -0,0 +1,33 @@
+import * as React from 'react';
+
+import { render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+
+import { VersionChooser } from '../../src/renderer/components/commands-version-chooser';
+import { AppState } from '../../src/renderer/state';
+import { mockVersion1, prepareAppState } from '../test-utils/versions';
+
+describe('VersionSelect component', () => {
+  let appState: AppState;
+
+  beforeEach(() => {
+    appState = prepareAppState();
+
+    // the version selector is disabled when bisecting
+    appState.Bisector = undefined;
+  });
+
+  it('selects a new version', async () => {
+    const { getByRole } = render(<VersionChooser appState={appState} />);
+
+    const btnOpenVersionSelector = getByRole('button');
+
+    await userEvent.click(btnOpenVersionSelector);
+
+    const versionButton = screen.getByText(mockVersion1.version);
+
+    await userEvent.click(versionButton);
+
+    expect(appState.setVersion).toHaveBeenCalledWith(mockVersion1.version);
+  });
+});

Diff for: tests/renderer/components/version-select-spec.tsx renamed to rtl-spec/components/version-select.spec.tsx

@@ -1,85 +1,43 @@
 import * as React from 'react';
 
-import { shallow } from 'enzyme';
+import { render } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
 import { mocked } from 'jest-mock';
 
 import {
-  ElectronReleaseChannel,
   InstallState,
   RunnableVersion,
   VersionSource,
-} from '../../../src/interfaces';
+} from '../../src/interfaces';
 import {
   VersionSelect,
   filterItems,
   getItemIcon,
   getItemLabel,
   renderItem,
-} from '../../../src/renderer/components/version-select';
-import { AppState } from '../../../src/renderer/state';
-import { disableDownload } from '../../../src/renderer/utils/disable-download';
-import { StateMock, VersionsMock } from '../../mocks/mocks';
+} from '../../src/renderer/components/version-select';
+import { disableDownload } from '../../src/renderer/utils/disable-download';
+import { mockVersion1, prepareAppState } from '../test-utils/versions';
 
 const { downloading, installed, missing, installing } = InstallState;
-const { remote, local } = VersionSource;
+const { local } = VersionSource;
 
-jest.mock('../../../src/renderer/utils/disable-download.ts');
+jest.mock('../../src/renderer/utils/disable-download.ts');
 
 describe('VersionSelect component', () => {
-  let store: AppState;
-
-  const mockVersion1 = {
-    source: remote,
-    state: missing,
-    version: '1.0.0',
-  };
-
-  const mockVersion2 = {
-    source: remote,
-    state: missing,
-    version: '3.0.0-unsupported',
-  };
-
-  beforeEach(() => {
-    ({ state: store } = window.app);
-
-    const { mockVersions } = new VersionsMock();
-    (store as unknown as StateMock).initVersions('2.0.2', {
-      ...mockVersions,
-      '1.0.0': { ...mockVersion1 },
-      '3.0.0-unsupported': { ...mockVersion2 },
-    });
-    store.channelsToShow = [
-      ElectronReleaseChannel.stable,
-      ElectronReleaseChannel.beta,
-    ];
-  });
-
-  const onVersionSelect = () => ({});
+  function renderVersionSelect() {
+    const appState = prepareAppState();
 
-  it('renders', () => {
-    const wrapper = shallow(
+    return render(
       <VersionSelect
-        appState={store}
+        appState={appState}
         currentVersion={mockVersion1}
-        onVersionSelect={onVersionSelect}
+        onVersionSelect={jest.fn()}
       />,
     );
-    expect(wrapper).toMatchSnapshot();
-  });
+  }
 
   describe('renderItem()', () => {
-    it('renders an item', () => {
-      const item = renderItem(mockVersion1, {
-        handleClick: () => ({}),
-        index: 0,
-        modifiers: { active: true, disabled: false, matchesPredicate: true },
-        query: '',
-      });
-
-      expect(item).toMatchSnapshot();
-    });
-
     it('returns null if it does not match predicate', () => {
       const item = renderItem(mockVersion1, {
         handleClick: () => ({}),
@@ -103,9 +61,9 @@ describe('VersionSelect component', () => {
         query: '',
       })!;
 
-      const ItemWrapper = shallow(item);
+      const { getAllByTestId } = render(item);
 
-      expect(ItemWrapper.find('.disabled-menu-tooltip')).toHaveLength(1);
+      expect(getAllByTestId('disabled-menu-item')).toHaveLength(1);
     });
 
     it('does not disable enabled download buttons when return value is false', () => {
@@ -118,9 +76,9 @@ describe('VersionSelect component', () => {
         query: '',
       })!;
 
-      const ItemWrapper = shallow(item);
+      const { queryAllByTestId } = render(item);
 
-      expect(ItemWrapper.exists('.disabled-menu-tooltip')).toBe(false);
+      expect(queryAllByTestId('disabled-menu-item')).toHaveLength(0);
     });
   });
 
@@ -233,4 +191,23 @@ describe('VersionSelect component', () => {
       expect(filterItems('nightly', versions)).toEqual(expected);
     });
   });
+
+  describe('renderVersionContextMenu()', () => {
+    it('copies the current version number to the clipboard', async () => {
+      const spy = jest
+        .spyOn(navigator.clipboard, 'writeText')
+        .mockImplementationOnce(jest.fn());
+
+      const { getByRole, getByText } = renderVersionSelect();
+
+      await userEvent.pointer({
+        keys: '[MouseRight]',
+        target: getByRole('button'),
+      });
+
+      await userEvent.click(getByText(/copy version number/i));
+
+      expect(spy).toHaveBeenCalledWith(mockVersion1.version);
+    });
+  });
 });

Diff for: rtl-spec/test-utils/versions.ts

@@ -0,0 +1,44 @@
+import {
+  ElectronReleaseChannel,
+  InstallState,
+  VersionSource,
+} from '../../src/interfaces';
+import { VersionsMock } from '../../tests/mocks/electron-versions';
+import { StateMock } from '../../tests/mocks/state';
+
+const { missing } = InstallState;
+const { remote } = VersionSource;
+
+export const mockVersion1 = {
+  source: remote,
+  state: missing,
+  version: '1.0.0',
+};
+
+export const mockVersion2 = {
+  source: remote,
+  state: missing,
+  version: '3.0.0-unsupported',
+};
+
+/**
+ * Initializes the app state with our mock versions.
+ */
+export function prepareAppState() {
+  const { state: appState } = window.app;
+
+  const { mockVersions } = new VersionsMock();
+
+  (appState as unknown as StateMock).initVersions('2.0.2', {
+    ...mockVersions,
+    '1.0.0': { ...mockVersion1 },
+    '3.0.0-unsupported': { ...mockVersion2 },
+  });
+
+  appState.channelsToShow = [
+    ElectronReleaseChannel.stable,
+    ElectronReleaseChannel.beta,
+  ];
+
+  return appState;
+}

Diff for: src/renderer/components/version-select.tsx

@@ -205,6 +205,7 @@ export const renderItem: ItemRenderer<RunnableVersion> = (
       >
         <MenuItem
           active={modifiers.active}
+          data-testid="disabled-menu-item"
           disabled={true}
           text={highlightText(item.version, query)}
           key={item.version}