Skip to content

Commit bd4d2a5

Browse files
committed
Fix unit tests to pass for newer OpenSSL versions
Adjust a couple of output checks to look for expected text anywhere in the output, instead of at specific lines, so tests will pass despite warning output like this: *** WARNING : deprecated key derivation used. Using -iter or -pbkdf2 would be better. See also #55
1 parent fc59f0d commit bd4d2a5

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

.github/workflows/run-bats-core-tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,8 @@ on:
1010

1111
jobs:
1212
test:
13-
# We use older Ubuntu for now to avoid warning from newer OpenSSL (#55)
14-
# which break output expectations in some (fragile) tests
15-
runs-on: ubuntu-16.04
13+
# Test on older Ubuntu with OpenSSL < 1.1 and newer with OpenSSL >= 1.1
14+
runs-on: [ubuntu-16.04, ubuntu-18.04]
1615

1716
steps:
1817
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it

tests/test_merge.bats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ load $BATS_TEST_DIRNAME/_test_helper.bash
8686

8787
run git merge branch-2
8888
[ "$status" -ne 0 ]
89-
[ "${lines[1]}" = "CONFLICT (content): Merge conflict in sensitive_file" ]
89+
[[ "${output}" = *"CONFLICT (content): Merge conflict in sensitive_file"* ]]
9090

9191
run cat sensitive_file
9292
[ "$status" -eq 0 ]

tests/test_pre_commit.bats

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,11 @@ load $BATS_TEST_DIRNAME/_test_helper.bash
4444
# an encrypted file
4545
run git commit -m "Added more"
4646
[ "$status" -ne 0 ]
47-
[ "${lines[0]}" = "Transcrypt managed file is not encrypted in the Git index: sensitive_file" ]
48-
[ "${lines[1]}" = "You probably staged this file using a tool that does not apply .gitattribute filters as required by Transcrypt." ]
49-
[ "${lines[2]}" = "Fix this by re-staging the file with a compatible tool or with Git on the command line:" ]
50-
[ "${lines[3]}" = " git reset -- sensitive_file" ]
51-
[ "${lines[4]}" = " git add sensitive_file" ]
47+
[[ "${output}" = *"Transcrypt managed file is not encrypted in the Git index: sensitive_file"* ]]
48+
[[ "${output}" = *"You probably staged this file using a tool that does not apply .gitattribute filters as required by Transcrypt."* ]]
49+
[[ "${output}" = *"Fix this by re-staging the file with a compatible tool or with Git on the command line:"* ]]
50+
[[ "${output}" = *" git reset -- sensitive_file"* ]]
51+
[[ "${output}" = *" git add sensitive_file"* ]]
5252
}
5353

5454
@test "pre-commit: warn and don't clobber existing pre-commit hook on init" {

0 commit comments

Comments
 (0)