Skip to content

The elasticsearch-transport gem will be promoted to its own repository #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
picandocodigo opened this issue Jun 4, 2021 · 11 comments
Closed

Comments

@picandocodigo
Copy link
Member

picandocodigo commented Jun 4, 2021

The gem elasticsearch-transport is currently being used as the HTTP transport layer for both the elasticsearch gem and the elastic-enterprise-search gem.

  • The functionality specific to Elasticsearch will be moved from elasticsearch-transport to elasticsearch and we'll decouple these two libraries.
  • elasticsearch-transport is going to be promoted to a new repository and renamed to elastic-transport in 8.0.0.

If you're using the elasticsearch gem, you shouldn't have to change anything as the dependencies will be kept up to date and the API shouldn't change. We'll try to keep any breaking changes only in 8.0.0 when possible. If you're using only elasticsearch-transport, you'll need to implement any Elasticsearch related features or switch to using elasticsearch.

@alimac
Copy link

alimac commented Aug 5, 2021

@picandocodigo Hi. fwiw, running into

NoMethodError: undefined method `logger' for #<Elasticsearch::Transport::Client:0x00007f8aef7d7e50>

when deleting/refreshing indices: elastic/elasticsearch-rails#998 (comment)

@picandocodigo
Copy link
Member Author

Hi @alimac, thanks for reporting this. I'll take a look as soon as possible!

@baranyeni
Copy link

Hi @picandocodigo @alimac I am facing with the exact same error afterwards updating my gems. Is there any current solution with this problem? Can we say it's an official bug, so I can just downgrade back and keep my work up?

@picandocodigo
Copy link
Member Author

@alimac and @baranyeni,
I've released elasticsearch-rails 7.2.0, please let me know if you're still having the issue after upgrading. Thanks!

@baranyeni
Copy link

Well, this specific problem is solved but I my unit tests are failing I think it is somehow related with this gem. When I update the elasticsearch-rails gem to gem 'elasticsearch-rails', github: 'elastic/elasticsearch-rails', ref: '583f1ed29dd6bae794f5087cca4dddb10126db14' #ver: 7.2.0 I saw below lines are removed from my Gemfile.lock so should I add them manually or what do you suggest?

  •  elasticsearch-model (7.1.1)
    
  •      activesupport (> 3)
    
  •      elasticsearch (> 1)
    
  •      hashie
    
  •  elasticsearch-rails (7.1.1)
    

@alimac
Copy link

alimac commented Aug 11, 2021

@baranyeni I believe you have to add

gem "elasticsearch-model"

to your Gemfile explicitly. At least, that's what I have.

And setting a minimum version:

gem "elasticsearch-model", "~> 7.2"

fixed the spec failures for me.

Thanks @picandocodigo for the quick response and release!

@baranyeni
Copy link

Thanks but it did not solved any of my errors.

@dshorthouse
Copy link

dshorthouse commented Aug 20, 2021

Is this also why am now getting:

NoMethodError - undefined method 'reload_connections!' for #<Elasticsearch::Transport::Client:0x00007fe2c31640d8>

Even though this method is clearly stated in the README?

@picandocodigo
Copy link
Member Author

Thanks for reporting this, I'm going to look into it and release a fix as soon as possible.

@tachyons
Copy link

NoMethodError: undefined method `transport' for #<Elasticsearch::Transport::Transport::HTTP::Faraday:0x00007f7fa42527d8>
from /Users/<>/.asdf/installs/ruby/2.6.6/lib/ruby/gems/2.6.0/gems/elasticsearch-model-7.2.0/lib/elasticsearch/model/indexing.rb:293:in `rescue in delete_index!'

Getting this error, potentially related ?

@picandocodigo
Copy link
Member Author

Closing this issue as completed.

Please report issues related to elasticsearch-model in elasticsearch-rails. We have been having some capacity issues to update that project, but we'll try to get into that when it's possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants