Skip to content

Commit d683a1a

Browse files
committed
[CLIENT] Meta header: Update JRuby implementation
1 parent 46fad98 commit d683a1a

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

elasticsearch-transport/lib/elasticsearch/transport/client.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ def meta_header_engine
237237
when 'ruby'
238238
{}
239239
when 'jruby'
240-
{ jr: JRUBY_VERSION }
240+
{ jv: ENV_JAVA['java.version'], jr: JRUBY_VERSION }
241241
when 'rbx'
242242
{ rbx: RUBY_VERSION }
243243
else

elasticsearch-transport/spec/elasticsearch/transport/meta_header_spec.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
describe Elasticsearch::Transport::Client do
2121
context 'meta-header' do
2222
let(:subject) { client.transport.connections.first.connection.headers }
23-
let(:regexp) { /^[a-z]{1,}=[a-z0-9.\-]{1,}(?:,[a-z]{1,}=[a-z0-9.\-]+)*$/ }
23+
let(:regexp) { /^[a-z]{1,}=[a-z0-9.\-]{1,}(?:,[a-z]{1,}=[a-z0-9._\-]+)*$/ }
2424
let(:adapter) { :net_http }
2525
let(:adapter_code) { "nh=#{defined?(Net::HTTP::VERSION) ? Net::HTTP::VERSION : Net::HTTP::HTTPVersion}" }
2626
let(:meta_header) do
27-
if RUBY_ENGINE == 'jruby'
28-
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jr=#{JRUBY_VERSION},fd=#{Faraday::VERSION},#{adapter_code}"
27+
if jruby?
28+
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jv=#{ENV_JAVA['java.version']},jr=#{JRUBY_VERSION},fd=#{Faraday::VERSION},#{adapter_code}"
2929
else
3030
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},fd=#{Faraday::VERSION},#{adapter_code}"
3131
end
@@ -77,8 +77,8 @@
7777

7878
context 'adapters' do
7979
let(:meta_header) do
80-
if RUBY_ENGINE == 'jruby'
81-
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jr=#{JRUBY_VERSION},fd=#{Faraday::VERSION}"
80+
if jruby?
81+
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jv=#{ENV_JAVA['java.version']},jr=#{JRUBY_VERSION},fd=#{Faraday::VERSION}"
8282
else
8383
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},fd=#{Faraday::VERSION}"
8484
end
@@ -166,8 +166,8 @@ def initialize(args); end
166166
let(:client) { Elasticsearch::Client.new(transport_class: MyTransport) }
167167
let(:subject){ client.instance_variable_get("@arguments")[:transport_options][:headers] }
168168
let(:meta_header) do
169-
if RUBY_ENGINE == 'jruby'
170-
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jr=#{JRUBY_VERSION}"
169+
if jruby?
170+
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION},jv=#{ENV_JAVA['java.version']},jr=#{JRUBY_VERSION}"
171171
else
172172
"es=#{Elasticsearch::VERSION},rb=#{RUBY_VERSION},t=#{Elasticsearch::Transport::VERSION}"
173173
end

0 commit comments

Comments
 (0)