Skip to content

Commit 8edd25b

Browse files
committed
Update code for update_version rake task.
1 parent 3877e37 commit 8edd25b

File tree

1 file changed

+12
-15
lines changed

1 file changed

+12
-15
lines changed

Rakefile

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -132,35 +132,32 @@ DESC
132132
task :update_version, :old, :new do |task, args|
133133
require 'ansi'
134134

135-
puts "[!!!] Required argument [old] missing".ansi(:red) unless args[:old]
136-
puts "[!!!] Required argument [new] missing".ansi(:red) unless args[:new]
135+
puts '[!!!] Required argument [old] missing'.ansi(:red) unless args[:old]
136+
puts '[!!!] Required argument [new] missing'.ansi(:red) unless args[:new]
137137

138138
files = Dir['**/**/version.rb','**/**/*.gemspec']
139139

140-
longest_line = files.map { |f| f.size }.max
140+
longest_line = files.map(&:size).max
141141

142-
puts "\n", "= FILES ".ansi(:faint) + ('='*92).ansi(:faint), "\n"
142+
puts"\n", '= FILES '.ansi(:faint) + ('='*92).ansi(:faint), "\n"
143143

144144
files.each do |file|
145145
begin
146-
File.open(file, 'r+') do |f|
147-
content = f.read
148-
if content.match Regexp.new(args[:old])
149-
content.gsub! Regexp.new(args[:old]), args[:new]
150-
puts "+ [#{file}]".ansi(:green).ljust(longest_line+20) + " [#{args[:old]}] -> [#{args[:new]}]".ansi(:green,:bold)
151-
f.rewind
152-
f.write content
153-
else
154-
puts "- [#{file}]".ansi(:yellow).ljust(longest_line+20) + " -".ansi(:faint,:strike)
155-
end
146+
content = File.read(file)
147+
if content.match Regexp.new(args[:old])
148+
content.gsub! Regexp.new(args[:old]), args[:new]
149+
puts "+ [#{file}]".ansi(:green).ljust(longest_line+20) + " [#{args[:old]}] -> [#{args[:new]}]".ansi(:green,:bold)
150+
File.open(file, 'w') { |f| f.puts content }
151+
else
152+
puts "- [#{file}]".ansi(:yellow).ljust(longest_line+20) + " -".ansi(:faint,:strike)
156153
end
157154
rescue Exception => e
158155
puts "[!!!] #{e.class} : #{e.message}".ansi(:red,:bold)
159156
raise e
160157
end
161158
end
162159

163-
puts "\n\n", "= CHANGELOG ".ansi(:faint) + ('='*88).ansi(:faint), "\n"
160+
puts "\n\n", '= CHANGELOG '.ansi(:faint) + ('='*88).ansi(:faint), "\n"
164161

165162
log = `git --no-pager log --reverse --no-color --pretty='* %s' HEAD --not v#{args[:old]} elasticsearch*`.split("\n")
166163

0 commit comments

Comments
 (0)