DoubleWithFractionalPortionConverter and FloatWithFractionalPortionConverter should not fall through to always throw a JSONException for non NETCore builds (#7753)

karl-sjogren · flobernd · commit ec55056ab828 · 2023-07-10T14:43:57.000+02:00
diff --git a/src/Elastic.Clients.Elasticsearch/Serialization/DoubleWithFractionalPortionConverter.cs b/src/Elastic.Clients.Elasticsearch/Serialization/DoubleWithFractionalPortionConverter.cs
@@ -75,6 +75,7 @@ public override void Write(Utf8JsonWriter writer, double value, JsonSerializerOp
 				if (bytes.Length < utf8bytes.Length)
 				{
 					bytes.CopyTo(utf8bytes);
+					return;
 				}
 			}
 			catch
diff --git a/src/Elastic.Clients.Elasticsearch/Serialization/FloatWithFractionalPortionConverter.cs b/src/Elastic.Clients.Elasticsearch/Serialization/FloatWithFractionalPortionConverter.cs
@@ -75,6 +75,7 @@ public override void Write(Utf8JsonWriter writer, float value, JsonSerializerOpt
 				if (bytes.Length < utf8bytes.Length)
 				{
 					bytes.CopyTo(utf8bytes);
+					return;
 				}
 			}
 			catch

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ public override void Write(Utf8JsonWriter writer, double value, JsonSerializerOp`
`75`	`75`	`if (bytes.Length < utf8bytes.Length)`
`76`	`76`	`{`
`77`	`77`	`bytes.CopyTo(utf8bytes);`
	`78`	`+ return;`
`78`	`79`	`}`
`79`	`80`	`}`
`80`	`81`	`catch`