Skip to content

Commit 0766e26

Browse files
committed
Allow extra parameters to Object fields
Fixes #895 Fixes #905
1 parent dda122f commit 0766e26

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

elasticsearch_dsl/field.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def empty(self):
169169
def to_dict(self):
170170
d = self._mapping.to_dict()
171171
_, d = d.popitem()
172-
d["type"] = self.name
172+
d.update(super(Object, self).to_dict())
173173
return d
174174

175175
def _collect_fields(self):

test_elasticsearch_dsl/test_field.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,13 @@ def test_object_dynamic_values():
142142
f = field.Object(dynamic=dynamic)
143143
assert f.to_dict()['dynamic'] == dynamic
144144

145+
def test_object_disabled():
146+
f = field.Object(enabled=False)
147+
assert f.to_dict() == {
148+
"type": "object",
149+
"enabled": False
150+
}
151+
145152

146153
def test_object_constructor():
147154
expected = {'type': 'object', 'properties': {'inner_int': {'type': 'integer'}}}

0 commit comments

Comments
 (0)