You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For mapped_pages that link to versionless AsciiDoc books (paths set to undefined in legacy-url-mappings.yml), we should not add a "Previous versions" link because it just redirects back to the v3 page.
You will be redirected to the same page you started on.
Tooling
docs-builder
migration tooling
I'm not sure
To pick up a draggable item, press the space bar.
While dragging, use the arrow keys to move the item.
Press space again to drop the item in its new position, or press escape to cancel.
@cotti can we just remove every entry with undefined as value?
Would that have the desired outcome?
Nope, we need a minor adjustment on the mapping logic. If we don't find a viable mapping, we are still yielding a LegacyPageMapping with empty values there rather than null. Skimming through its usage here, seems safe to just allow it to return null. The method's signature already predicts it anyway, and it's the return in case we don't have a list of mapped pages in the first place.
Activity
reakaleek commentedon May 15, 2025
@cotti can we just remove every entry with undefined as value?
Would that have the desired outcome?
cotti commentedon May 23, 2025
Nope, we need a minor adjustment on the mapping logic. If we don't find a viable mapping, we are still yielding a LegacyPageMapping with empty values there rather than null. Skimming through its usage here, seems safe to just allow it to return null. The method's signature already predicts it anyway, and it's the return in case we don't have a list of mapped pages in the first place.
bmorelli25 commentedon Jul 11, 2025
This is fixed. Thanks.