Address a bunch of code-analysis quick fixes (#1761)

Author: Mpdreamz

aspire/AppHost.cs

@@ -5,7 +5,6 @@
 
 using ConsoleAppFramework;
 using Elastic.Documentation;
-using Elastic.Documentation.Configuration;
 using Microsoft.Extensions.Logging;
 using static Elastic.Documentation.Aspire.ResourceNames;
 
@@ -29,6 +28,7 @@
 return;
 
 // ReSharper disable once RedundantLambdaParameterType
+// ReSharper disable once VariableHidesOuterVariable
 async Task BuildAspireHost(bool startElasticsearch, bool assumeCloned, bool skipPrivateRepositories, Cancel ctx)
 {
 	var builder = DistributedApplication.CreateBuilder(args);

src/Elastic.ApiExplorer/Endpoints/IndexViewModel.cs

@@ -2,9 +2,6 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using Elastic.ApiExplorer.Landing;
-using Elastic.Documentation;
-
 namespace Elastic.ApiExplorer.Endpoints;
 
 public class IndexViewModel(ApiRenderContext context) : ApiViewModel(context)

src/Elastic.Documentation.Configuration/Assembler/AssemblyConfiguration.cs

@@ -90,10 +90,8 @@ private static TRepository RepositoryDefaults<TRepository>(TRepository r, string
 		};
 		// ensure we always null path if we are running in CI
 		if (!string.IsNullOrWhiteSpace(Environment.GetEnvironmentVariable("CI")))
-			repository = repository with
-			{
-				Path = null
-			};
+			repository = repository with { Path = null };
+
 		if (string.IsNullOrEmpty(repository.Origin))
 		{
 			if (!string.IsNullOrEmpty(Environment.GetEnvironmentVariable("GITHUB_ACTIONS")))
@@ -149,10 +147,8 @@ public ContentSourceMatch Match(string repository, string branchOrTag)
 			var next = r.GetBranch(ContentSource.Next);
 			var isVersionBranch = ContentSourceRegex.MatchVersionBranch().IsMatch(branchOrTag);
 			if (current == branchOrTag)
-				match = match with
-				{
-					Current = ContentSource.Current
-				};
+				match = match with { Current = ContentSource.Current };
+
 			if (next == branchOrTag)
 				match = match with
 				{

src/Elastic.Documentation.Configuration/Assembler/Repository.cs

@@ -2,7 +2,6 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using System.Collections;
 using System.Runtime.Serialization;
 using YamlDotNet.Serialization;
 

src/Elastic.Documentation.Configuration/ConfigurationFileProvider.cs

@@ -7,7 +7,6 @@
 using Elastic.Documentation.Configuration.Assembler;
 using Microsoft.Extensions.DependencyInjection;
 using NetEscapades.EnumGenerators;
-using YamlDotNet.RepresentationModel;
 
 namespace Elastic.Documentation.Configuration;
 

src/Elastic.Documentation.Configuration/Serialization/YamlStaticContext.cs

@@ -4,7 +4,6 @@
 
 using Elastic.Documentation.Configuration.Assembler;
 using Elastic.Documentation.Configuration.Versions;
-using YamlDotNet.RepresentationModel;
 using YamlDotNet.Serialization;
 
 namespace Elastic.Documentation.Configuration.Serialization;

src/Elastic.Documentation.Configuration/Versions/VersionsConfigurationExtensions.cs

@@ -2,7 +2,6 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using System.IO.Abstractions;
 using Elastic.Documentation.Configuration.Serialization;
 using YamlDotNet.Serialization;
 using YamlDotNet.Serialization.NamingConventions;

src/Elastic.Documentation.ServiceDefaults/Extensions.cs

@@ -9,7 +9,6 @@
 using Microsoft.Extensions.Hosting;
 using Microsoft.Extensions.Logging;
 using OpenTelemetry;
-using OpenTelemetry.Logs;
 using OpenTelemetry.Metrics;
 using OpenTelemetry.Trace;
 
@@ -57,9 +56,9 @@ public static TBuilder ConfigureOpenTelemetry<TBuilder>(this TBuilder builder) w
 			.WithTracing(tracing =>
 			{
 				_ = tracing.AddSource(builder.Environment.ApplicationName)
-					.AddAspNetCoreInstrumentation(tracing =>
+					.AddAspNetCoreInstrumentation(instrumentation =>
 						// Exclude health check requests from tracing
-						tracing.Filter = context =>
+						instrumentation.Filter = context =>
 							!context.Request.Path.StartsWithSegments(HealthEndpointPath)
 							&& !context.Request.Path.StartsWithSegments(AlivenessEndpointPath)
 					)

src/Elastic.Documentation.Site/Htmx.cs

@@ -2,10 +2,7 @@
 // Elasticsearch B.V licenses this file to you under the Apache 2.0 License.
 // See the LICENSE file in the project root for more information
 
-using System.Reflection;
 using System.Text;
-using System.Text.Encodings.Web;
-using Elastic.Documentation.Extensions;
 
 namespace Elastic.Documentation.Site;
 

src/Elastic.Documentation.Site/Layout/_SecondaryNav.cshtml

@@ -1,4 +1,3 @@
-@using Elastic.Documentation.Configuration.Builder
 @inherits RazorSlice<Elastic.Documentation.Site.GlobalLayoutViewModel>
 <nav id="secondary-nav" hx-disable="true" class="bg-grey-10 border-t-1 border-grey-20 font-sans font-semibold text-sm text-ink-light md:text-base">
 	<div class="max-w-(--max-layout-width) flex mx-auto justify-between items-center p-6">