[Rule Tuning] ESQL Query Field Dynamic Field Standardization #4912
+2,512
−1,256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle User Over a Session
…gle User Over a Session
…ithin a Single Blocked Request
|
⛔️ Test failed Results |
|
⛔️ Test failed Results |
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results |
…eld-standardization
|
⛔️ Test failed Results
|
|
⛔️ Test failed Results |
|
⛔️ Test failed Results
|
Samirbous
approved these changes
Jul 16, 2025
| | where webdav_target is not null and webdav_target rlike """(([a-zA-Z0-9-]+\.)+[a-zA-Z]{2,3}(@SSL.*)*|(\d{1,3}\.){3}\d{1,3})""" and not webdav_target in ("www.google.com@SSL", "www.elastic.co@SSL") and not webdav_target rlike """(10\.(\d{1,3}\.){2}\d{1,3}|172\.(1[6-9]|2\d|3[0-1])\.(\d{1,3}\.)\d{1,3}|192\.168\.(\d{1,3}\.)\d{1,3})""" | ||
| | stats total = count(*), unique_count_host = count_distinct(host.id), hosts = VALUES(host.id), users = VALUES(user.name) by webdav_target | ||
| | where unique_count_host == 1 and total <= 3 | ||
| | WHERE |
There was a problem hiding this comment.
this one works as expected 👍 to be in the safe side will be ideal to run all those changed queries against testing cluster to make sure they still match on thing.
|
⛔️ Test failed Results |
|
⛔️ Test failed Results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Adjusts all ESQL queries in detection rules to standard field names based on previously established guidelines. Please see related issue and other related issues for more details.
How To Test
Almost all queries have been tested in the TRADE serverless stack to confirm logic was not adjusted unintentionally. It is recommended that anyone reviewing - if a query was written by them to test it on their own dataset to ensure logic has not changed.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist