Fix compile errors from MSVC

There are still warnings, but these are less important to fix.

Author: Manu Goyal

libcuckoo/cuckoohash_map.hh

@@ -2447,7 +2447,7 @@ public:
 
       // Re-size the locks, and set the size to the stored size
       lt.maybe_resize_locks(lt.bucket_count());
-      for (spinlock &lock : lt.get_current_locks()) {
+      for (auto &lock : lt.get_current_locks()) {
         lock.elem_counter() = 0;
       }
       size_type size;

tests/pcg/pcg_random.hpp

@@ -1203,7 +1203,7 @@ class extended : public baseclass {
         return baseclass::period_pow2() + table_size*extvalclass::period_pow2();
     }
 
-    __attribute__((always_inline)) result_type operator()()
+    result_type operator()()
     {
         result_type rhs = get_extended_value();
         result_type lhs = this->baseclass::operator()();

tests/pcg/pcg_uint128.hpp

@@ -65,7 +65,7 @@
         #define PCG_LITTLE_ENDIAN 1
     #elif __BIG_ENDIAN__ || _BIG_ENDIAN
         #define PCG_LITTLE_ENDIAN 0
-    #elif __x86_64 || __x86_64__ || __i386 || __i386__
+    #elif __x86_64 || __x86_64__ || __i386 || __i386__ || _M_IX86 || _M_X64
         #define PCG_LITTLE_ENDIAN 1
     #elif __powerpc__ || __POWERPC__ || __ppc__ || __PPC__ \
           || __m68k__ || __mc68000__

tests/stress-tests/stress_checked.cc

@@ -14,7 +14,6 @@
 #include <random>
 #include <stdexcept>
 #include <thread>
-#include <unistd.h>
 #include <utility>
 #include <vector>
 
@@ -277,7 +276,7 @@ template <class KType> void StressTest(AllEnvironment<KType> *env) {
     }
   }
   // Sleeps before ending the threads
-  sleep(g_test_len);
+  std::this_thread::sleep_for(std::chrono::seconds(g_test_len));
   env->finished.store(true);
   for (size_t i = 0; i < threads.size(); i++) {
     threads[i].join();

tests/stress-tests/stress_unchecked.cc

@@ -13,7 +13,6 @@
 #include <random>
 #include <stdint.h>
 #include <thread>
-#include <unistd.h>
 #include <utility>
 #include <vector>
 
@@ -168,7 +167,7 @@ void resize_thread(AllEnvironment<KType> *env, size_t thread_seed) {
   pcg64_fast gen(thread_seed);
   // Resizes at a random time
   const size_t sleep_time = gen() % g_test_len;
-  sleep(sleep_time);
+  std::this_thread::sleep_for(std::chrono::seconds(sleep_time));
   if (env->finished.load()) {
     return;
   }
@@ -188,7 +187,7 @@ void iterator_thread(AllEnvironment<KType> *env, size_t thread_seed) {
   pcg64_fast gen(thread_seed);
   // Runs an iteration operation at a random time
   const size_t sleep_time = gen() % g_test_len;
-  sleep(sleep_time);
+  std::this_thread::sleep_for(std::chrono::seconds(sleep_time));
   if (env->finished.load()) {
     return;
   }
@@ -219,7 +218,7 @@ void clear_thread(AllEnvironment<KType> *env, size_t thread_seed) {
   pcg64_fast gen(thread_seed);
   // Runs a clear operation at a random time
   const size_t sleep_time = gen() % g_test_len;
-  sleep(sleep_time);
+  std::this_thread::sleep_for(std::chrono::seconds(sleep_time));
   if (env->finished.load()) {
     return;
   }
@@ -256,7 +255,7 @@ template <class KType> void StressTest(AllEnvironment<KType> *env) {
     }
   }
   // Sleeps before ending the threads
-  sleep(g_test_len);
+  std::this_thread::sleep_for(std::chrono::seconds(g_test_len));
   env->finished.store(true);
   for (size_t i = 0; i < threads.size(); i++) {
     threads[i].join();

tests/unit-tests/test_resize.cc

@@ -44,12 +44,12 @@ TEST_CASE("reserve calc", "[resize]") {
               2500000 * slot_per_bucket) == 22);
 
   REQUIRE(UnitTestInternalAccess::reserve_calc<IntIntTable>(
-              (1UL << 31) * slot_per_bucket) == 31);
+              (1ULL << 31) * slot_per_bucket) == 31);
   REQUIRE(UnitTestInternalAccess::reserve_calc<IntIntTable>(
-              ((1UL << 31) + 1) * slot_per_bucket) == 32);
+              ((1ULL << 31) + 1) * slot_per_bucket) == 32);
 
   REQUIRE(UnitTestInternalAccess::reserve_calc<IntIntTable>(
-              (1UL << 61) * slot_per_bucket) == 61);
+              (1ULL << 61) * slot_per_bucket) == 61);
   REQUIRE(UnitTestInternalAccess::reserve_calc<IntIntTable>(
               ((1ULL << 61) + 1) * slot_per_bucket) == 62);
 }