Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jan 2023 - For Github Owner: Run the repo sync script locally #58

Closed
6 tasks done
robrap opened this issue Sep 6, 2022 · 3 comments
Closed
6 tasks done

Jan 2023 - For Github Owner: Run the repo sync script locally #58

robrap opened this issue Sep 6, 2022 · 3 comments
Assignees

Comments

@robrap
Copy link
Contributor

robrap commented Sep 6, 2022

A script runs in Jenkins automatically against repos, but it may miss repos that it can't yet see. Running it locally by someone with admin access will help us get a list of any repos we missed.

Instructions can be found here: https://2u-internal.atlassian.net/wiki/spaces/AT/pages/16385737/Manual+Ownership+Repo+Sync+Script+Running

AC:

  • Run ownership script locally and follow the runbook for newly found repos.
  • Make a new duplicate of this ticket to run this again next quarter:
    • status:backlog
    • priority:P3
    • Due Date: 3-6 months from now
    • Add comment to this ticket pointing to the new ticket.
@robrap robrap removed the backlog To be put on a team's backlog or wishlist label Apr 20, 2023
@robrap
Copy link
Contributor Author

robrap commented Jul 14, 2023

  • Is the script equipped to work for edx and openedx orgs?
  • Does it matter if we miss openedx repos?
  • Do we need Axim to run this script for us for openedx?
  • The runbook mentions repos require one of the following teams: @pull-all and @ownership-sync-read-only. Is this true for openedx repos as well?

@jristau1984 jristau1984 moved this from Prioritized to Backlog in Arch-BOM Jul 1, 2024
@robrap
Copy link
Contributor Author

robrap commented Dec 16, 2024

While reviewing tickets with a Due Date, I noticed this ticket, so I took a small action.

  • I ran the script on Dec 16, 2024 (results below). It took me ~15 minutes to get it running, and this included updating the docs.
  • The rest of the runbook would still need to be run through if we want to provide visibility to the script.
    • I think we can skip private openedx repos.
      • This is fine and shouldn't affect many people.
    • In the runbook, maybe we mention additional repos to ignore and leave off the spreadsheet? For example: edx/sandbox-<username>.
      • There are lots of terraform module repos. Do we want rows to track ownership, or to ignore?
      • Note: fixing repos shouldn't take too long if the list is manageable.
      • We decided to simply add the missing repos following the runbook.
    • I'm not clear why the Jenkins job isn't seeing some of the openedx archiving?

@jristau1984: This tickets is currently a P5. Let's discuss how to best proceed.

  • I decided that this and new tickets of this nature should just be a P3. It is simple, and simply needs to get done.
  • More repos will be created privately, and it would be great to have them in the spreadsheet.
  • Maybe we can double-check HelpDesk docs to ensure that repos are set up right to begin with?
    • I created a HelpDesk ticket to update their process and hopefully make this simpler to resolve.
  • Now that we have more data (see below), is this something that would be good to fix preemptively (i.e. before someone requires this ownership info), or before someone wants to argue that they don't own something just because they created it?
    • We decided to move ahead and just implement this.
Action: Add repo to spreadsheet -- Repo present in Github but not spreadsheet
- edx/2u-rv-snippets
- edx/ansible-private
- edx/ct-merchantcenter-custom-views
- edx/edx-ecommerce-extension
- edx/edx-minos
- edx/frontend-plugin-authn
- edx/frontend-plugin-learner-dashboard
- edx/frontend-plugin-persona
- edx/frontend-plugin-recommendations
- edx/powerreviews-scripts
- edx/product-card
- edx/sandbox--tpasipamire
- edx/sandbox-cswethar
- edx/sandbox-koffemaria2u
- edx/sandbox-krispyren
- edx/sandbox-smallery
- edx/tf-module-acm-cert
- edx/tf-module-asgard
- edx/tf-module-aurora-alerts
- edx/tf-module-aws-transit-gateway
- edx/tf-module-cluster
- edx/tf-module-config-s3-iam-policy
- edx/tf-module-datadog-apm-common-service-monitors
- edx/tf-module-datadog-estimated-usage-monitors
- edx/tf-module-datadog-heartbeat-monitors
- edx/tf-module-datadog-infrastructure-monitors
- edx/tf-module-datadog-logs-monitors
- edx/tf-module-datadog-service-check
- edx/tf-module-datadog-synthetics-ping
- edx/tf-module-dig-security-monitored-account
- edx/tf-module-dig-security-orchestrator-account
- edx/tf-module-dig-security-orchestrator-role
- edx/tf-module-dig-security-readonly-role
- edx/tf-module-dig-security-scanner-role
- edx/tf-module-ecr-registry
- edx/tf-module-eks-autoscaling-policy
- edx/tf-module-eks-network
- edx/tf-module-eks-pod-role-assumption-policy
- edx/tf-module-eks-static-assets
- edx/tf-module-eks-vault
- edx/tf-module-elasticache-alerts
- edx/tf-module-elasticsearch
- edx/tf-module-elb-alerts
- edx/tf-module-elb_tls_1_1_policy
- edx/tf-module-mongo-alerts
- edx/tf-module-mongo-instances
- edx/tf-module-nat
- edx/tf-module-opensearch
- edx/tf-module-opsgenie
- edx/tf-module-pagerduty-service
- edx/tf-module-rapid7-access
- edx/tf-module-rds-aurora-io-bucket-and-policy
- edx/tf-module-rds-cluster
- edx/tf-module-rds-logs-alerts
- edx/tf-module-s3-logging
- edx/tf-module-standard-s3-iam-policy
- edx/tf-module-vpc
- edx/tf-module-webservice
- openedx/openedx-website
``

**IMPORTANT**: Do **not** make the following changes. That should be left for this new ticket:
- https://github.com/edx/edx-arch-experiments/issues/880

Action: Delete row from spreadsheet -- Moved to a Github org not in the scan list

  • openedx/mdrst {"new_location": "openedx-unsupported/mdrst", "row_id": 82}
  • openedx/onboarding-course-introduction {"new_location": "openedx-unsupported/onboarding-course-introduction", "row_id": 117}
  • openedx/pinax-announcements {"new_location": "openedx-unsupported/pinax-announcements", "row_id": 40}

@robrap robrap removed the status in Arch-BOM Dec 18, 2024
@robrap robrap moved this to Ready For Development in Arch-BOM Dec 18, 2024
@robrap robrap moved this from Ready For Development to In Progress in Arch-BOM Dec 18, 2024
@robrap robrap self-assigned this Dec 18, 2024
@robrap
Copy link
Contributor Author

robrap commented Dec 18, 2024

I'm going to close this ticket.

@robrap robrap closed this as completed Dec 18, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Arch-BOM Dec 18, 2024
@jristau1984 jristau1984 moved this from Done to Done - Long Term Storage in Arch-BOM Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - Long Term Storage
Development

No branches or pull requests

1 participant