-
Notifications
You must be signed in to change notification settings - Fork 10
fix: update pip version constraint to avoid compatibility issues with pip-tools #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a version constraint to prevent pip from upgrading to version 25.x, which is incompatible with the currently-used pip-tools 7.5.1. The constraint addresses an AttributeError related to 'use_pep517' that occurs when pip 25.x is used with pip-tools 7.5.1.
- Adds a pip version constraint (
pip<25.0) to the constraints file - Includes explanatory comments documenting the incompatibility issue and the rationale for the constraint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chintanjoshi-apphelix-2u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There needs to be an issue created as well for this.
Which should be linked here as well.
And the issue needs reasoning as to why this is pinned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chintanjoshi-apphelix-2u
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Ticket
https://2u-internal.atlassian.net/browse/BOMS-277
Summary
There is a breakage currently in pip-tools that failed several / many / all? python requirement upgrades: jazzband/pip-tools#2252 The temporary solution may be to pin pip to the last minor version, but it does look like a fix in on the way.
Findings
The error is stemming from the removal of the legacy setup.py bdist_wheel support in pypa/pip#6334 which removes the optional flag --use-pip517 that had been added for the support of deprecated legacy functionality.
Since all versions of pip-tools utilize this flag for the pip-compile command, the new version pip==25.3 is now breaking with all the versions of pip-tools hence the need to pin pip as a solution for this until pip-tools provide a workaround for this issue in their next release.