Skip to content

Commit 01d773f

Browse files
authored
feat: Use common edx- prefix for Datadog service: tag (#4)
1 parent 307b910 commit 01d773f

File tree

9 files changed

+10
-9
lines changed

9 files changed

+10
-9
lines changed

playbooks/roles/ecomworker/templates/edx/app/ecomworker/ecomworker.sh.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export NEW_RELIC_LICENSE_KEY='{{ NEWRELIC_LICENSE_KEY }}'
1616

1717
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
1818
{% set executable = ecommerce_worker_venv_bin + '/ddtrace-run ' + executable %}
19-
export DD_TAGS="service:{{ ecommerce_worker_service_name }}"
19+
export DD_TAGS="service:edx-{{ ecommerce_worker_service_name }}"
2020
export DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT=true
2121
# Copied from edx_django_service playbook for consistency; Datadog
2222
# trace debug logging issue doesn't actually affect edxapp for some

playbooks/roles/edx_django_service/defaults/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ edx_django_service_basic_auth_exempted_paths: '{{ edx_django_service_basic_auth_
103103

104104
edx_django_service_newrelic_appname: '{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-{{ edx_django_service_name }}'
105105
edx_django_service_enable_newrelic_distributed_tracing: false
106+
edx_django_datadog_service: 'edx-{{ edx_django_service_name }}'
106107

107108
edx_django_service_repos:
108109
- PROTOCOL: '{{ edx_django_service_git_protocol }}'

playbooks/roles/edx_django_service/templates/edx/app/app/app.sh.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
2222

2323
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
2424
{% set executable = edx_django_service_venv_bin + '/ddtrace-run ' + executable %}
25-
export DD_TAGS="service:{{ edx_django_service_name }}"
25+
export DD_TAGS="service:{{ edx_django_datadog_service }}"
2626
export DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT=true
2727
# Workaround for
2828
# https://github.com/edx/edx-arch-experiments/issues/591 (heavy

playbooks/roles/edxapp/templates/edx/app/edxapp/cms.sh.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
2222

2323
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
2424
{% set executable = edxapp_venv_bin + '/ddtrace-run ' + executable %}
25-
export DD_TAGS="service:edxapp-cms"
25+
export DD_TAGS="service:edx-edxapp-cms"
2626
export DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT=true
2727
# Copied from edx_django_service playbook for consistency; Datadog
2828
# trace debug logging issue doesn't actually affect edxapp for some

playbooks/roles/edxapp/templates/edx/app/edxapp/lms.sh.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
2222

2323
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
2424
{% set executable = edxapp_venv_bin + '/ddtrace-run ' + executable %}
25-
export DD_TAGS="service:edxapp-lms"
25+
export DD_TAGS="service:edx-edxapp-lms"
2626
export DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT=true
2727
# Copied from edx_django_service playbook for consistency; Datadog
2828
# trace debug logging issue doesn't actually affect edxapp for some

playbooks/roles/forum/defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ FORUM_NEW_RELIC_LICENSE_KEY: '{{ NEWRELIC_LICENSE_KEY | default("") }}'
5050
FORUM_NEW_RELIC_APP_NAME: "{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-forum"
5151

5252
# Datadog CONFIG
53-
FORUM_DD_TAGS: "service:forum"
53+
FORUM_DD_TAGS: "service:edx-forum"
5454

5555
FORUM_WORKER_PROCESSES: "4"
5656
FORUM_LISTEN_HOST: "0.0.0.0"

playbooks/roles/insights/templates/edx/app/insights/insights.sh.j2

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export NEW_RELIC_LICENSE_KEY="{{ NEWRELIC_LICENSE_KEY }}"
1616

1717
{% if COMMON_ENABLE_DATADOG and COMMON_ENABLE_DATADOG_APP %}
1818
{% set executable = insights_venv_bin + '/ddtrace-run ' + executable %}
19-
export DD_TAGS="service:{{ insights_service_name }}"
19+
export DD_TAGS="service:edx-{{ insights_service_name }}"
2020
export DD_DJANGO_USE_LEGACY_RESOURCE_FORMAT=true
2121
# Copied from edx_django_service playbook for consistency; Datadog
2222
# trace debug logging issue doesn't actually affect edxapp for some

playbooks/roles/xqueue/defaults/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ XQUEUE_MYSQL_CONN_MAX_AGE: 0 # This is Django's default https://docs.djangoproje
5959
XQUEUE_NEWRELIC_APPNAME: "{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-xqueue"
6060
XQUEUE_CONSUMER_NEWRELIC_APPNAME: "{{ COMMON_ENVIRONMENT }}-{{ COMMON_DEPLOYMENT }}-xqueue_consumer"
6161

62-
XQUEUE_CONSUMER_DATADOG_APPNAME: "xqueue_consumer"
63-
XQUEUE_DATADOG_APPNAME: "{{ xqueue_service_name }}"
62+
XQUEUE_CONSUMER_DATADOG_APPNAME: "edx-xqueue_consumer"
63+
XQUEUE_DATADOG_APPNAME: "edx-{{ xqueue_service_name }}"
6464

6565
# Set the number of gunicorn front end workers explicitely for xqueue
6666
XQUEUE_WORKERS: !!null

playbooks/roles/xqwatcher/defaults/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ XQWATCHER_REPOS:
7575
XQWATCHER_NEWRELIC_APPNAME: "{{ COMMON_DEPLOYMENT }}-{{ COMMON_ENVIRONMENT }}-xqwatcher"
7676
XQWATCHER_PIP_EXTRA_ARGS: "-i {{ COMMON_PYPI_MIRROR_URL }}"
7777

78-
XQWATCHER_DATADOG_APPNAME: "{{ xqwatcher_service_name }}"
78+
XQWATCHER_DATADOG_APPNAME: "edx-{{ xqwatcher_service_name }}"
7979
#
8080
#
8181
# vars are namespace with the module name.

0 commit comments

Comments
 (0)