Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some owner references should not be marked as controller. #631

Open
GrahamDumpleton opened this issue Feb 4, 2025 · 0 comments
Open

Some owner references should not be marked as controller. #631

GrahamDumpleton opened this issue Feb 4, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@GrahamDumpleton
Copy link
Collaborator

Describe the bug

Owner reference from WorkshopSession back to WorkshopEnvironment, and from WorkshopEnvironment back to TrainingPortal, set the controller property to true. These should not really set controller to true since the owner reference only exists in this case to ensure garbage collection, and are not necessarily indicative of what is the controller in the Kubernetes sense of what is a controller.

Lots of other arbitrary resources created for environments and sessions similarly set controller to true when can be argued they shouldn't. Should review all owner references and perhaps set controller to false in most cases.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant