Skip to content

Commit c827dca

Browse files
authored
Merge pull request #541 from wes-johnson/develop
[#61] Optimized protobuf DataSet definition
2 parents 764b2e5 + 3bdf644 commit c827dca

File tree

1 file changed

+15
-25
lines changed

1 file changed

+15
-25
lines changed

specification/src/main/asciidoc/chapters/Sparkplug_6_Payloads.adoc

Lines changed: 15 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -213,33 +213,23 @@ message Payload {
213213
214214
message DataSet {
215215
216-
message DataSetValue {
217-
218-
oneof value {
219-
uint32 int_value = 1;
220-
uint64 long_value = 2;
221-
float float_value = 3;
222-
double double_value = 4;
223-
bool boolean_value = 5;
224-
string string_value = 6;
225-
DataSetValueExtension extension_value = 7;
226-
}
227-
228-
message DataSetValueExtension {
229-
extensions 1 to max;
230-
}
231-
}
232-
233-
message Row {
234-
repeated DataSetValue elements = 1;
235-
extensions 2 to max; // For third party extensions
216+
message Column {
217+
optional string name = 1;
218+
optional uint32 type = 2;
219+
220+
// Only one type of repeated value shall be used per Column
221+
repeated uint32 int_values = 3 [packed=true];
222+
repeated uint64 long_values = 4 [packed=true];
223+
repeated float float_values = 5 [packed=true];
224+
repeated double double_values = 6 [packed=true];
225+
repeated bool boolean_values = 7 [packed=true];
226+
repeated string string_values = 8 [packed=false];
227+
228+
extensions 9 to max;
236229
}
237230
238-
optional uint64 num_of_columns = 1;
239-
repeated string columns = 2;
240-
repeated uint32 types = 3;
241-
repeated Row rows = 4;
242-
extensions 5 to max; // For third party extensions
231+
repeated Column columns = 1;
232+
extensions 2 to max;
243233
}
244234
245235
message PropertyValue {

0 commit comments

Comments
 (0)