Skip to content

Conversation

@dmatej
Copy link
Contributor

@dmatej dmatej commented Nov 28, 2025

  • Refactoring around GFLauncher and both children
  • Fixed printing output for restart-domain
  • Fixed links to JPDA
  • Improved output of start/restart commands
    • ie. Konsole in KDE now allows to click directly on the admin endpoint link and open it in a default browser
  • I did not document other parameters added in More flexibility to control server start #25790 , because it is not much safe to use them as I tried locally and on Windows machines. They might be useful sometimes, however, ie. when we start docker container, and we don't care about the admin port, just about PID. However there we would still use rather start-serv ... it depends, because sometimes I am restarting domain in container, and in such case I prefer asadmin. We have pretty flexible monster ;-)
/usr/lib/jvm/jdk25/bin/java ./glassfish7/bin/asadmin.java restart-domain 
Server is not running, will attempt to start it...
Waiting until start of domain domain1 completes.. ... finished after 1446 ms.

Successfully started the domain domain1.
  Location: /app/appservers/glassfish7/glassfish/domains/domain1
  Log File: /app/appservers/glassfish7/glassfish/domains/domain1/logs/server.log
  The pid file /app/appservers/glassfish7/glassfish/domains/domain1/config/pid contains pid 2462207.
  Process with pid 2462207 is alive
  Admin Endpoints:
    http://localhost:4848 is reachable.

Command restart-domain executed successfully.

- Some user messages moved to later phase so user would not miss them
- Better separation of server and embedded, now I can see what is not
  supported by embedded's launcher
- Improved user output.

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- other are rather experimental, so I will not document them for now

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej added this to the 7.1.0 milestone Nov 28, 2025
@dmatej dmatej requested a review from a team November 28, 2025 01:13
Signed-off-by: David Matějček <[email protected]>
@arjantijms arjantijms merged commit 3dc52fb into eclipse-ee4j:master Nov 28, 2025
6 checks passed
@arjantijms arjantijms deleted the restartdocs branch November 28, 2025 13:16
connections to the Specifies whether the domain is restarted with
https://docs.oracle.com/en/java/javase/17/docs/specs/jpda/jpda.html[Java Platform Debugger Architecture (JPDA)]
debugging enabled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that https://glassfish.org/docs/SNAPSHOT/reference-manual.html#copy-config is not updated with that (yet?) - so can't check how this is rendered - but I don't understand that part in bold already:

This property specifies the port number of the port that is used for
connections to the Specifies whether the domain is restarted with

For me, there is something not right with that sentence...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is on my list as next item 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants