Debug port can be still unbindable after previous JVM died

- We have issues on Windows on GHA with this.
- Maybe local restarts should be done as stop-start on Windows?
  Respawning is not recommended and on windows it seems really risky

Signed-off-by: David Matějček <[email protected]>

Author: dmatej

appserver/itest-tools/src/main/java/org/glassfish/main/itest/tools/asadmin/Asadmin.java

@@ -242,7 +242,7 @@ private File getPasswordFile() {
      */
     private AsadminResult exec(final Integer timeout, final boolean detachedAndTerse, final String... args) {
         final List<String> parameters = Arrays.asList(args);
-        LOG.log(TRACE, "exec(timeout={0}, detached={1}, args={2})", timeout, detachedAndTerse, parameters);
+        LOG.log(INFO, "exec(timeout={0}, detached={1}, args={2})", timeout, detachedAndTerse, parameters);
         final List<String> command = new ArrayList<>();
         if (asadmin.getName().endsWith(".java")) {
             command.add(JAVA_EXECUTABLE);

appserver/tests/admin/tests/src/test/java/org/glassfish/main/admin/test/AsadminLoggingITest.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2022, 2024 Contributors to the Eclipse Foundation.
+ * Copyright (c) 2022, 2025 Contributors to the Eclipse Foundation.
  *
  * This program and the accompanying materials are made available under the
  * terms of the Eclipse Public License v. 2.0, which is available at
@@ -16,6 +16,8 @@
 
 package org.glassfish.main.admin.test;
 
+import com.sun.enterprise.util.OS;
+
 import java.io.File;
 import java.io.FileReader;
 import java.io.LineNumberReader;
@@ -69,11 +71,16 @@ public class AsadminLoggingITest {
 
     private static final Asadmin ASADMIN = GlassFishTestEnvironment.getAsadmin();
 
+    /** Fill up the server log. */
     @BeforeAll
-    public static void fillUpServerLog() {
-        // Fill up the server log.
-        AsadminResult result = ASADMIN.exec("restart-domain", "--timeout", "60");
-        assertThat(result, asadminOK());
+    public static void fillUpServerLog() throws Exception {
+        if (OS.isWindowsForSure()) {
+            // For some reason windows can collide on debug port.
+            assertThat(ASADMIN.exec("stop-domain"), asadminOK());
+            assertThat(ASADMIN.exec("start-domain"), asadminOK());
+        } else {
+            assertThat(ASADMIN.exec("restart-domain"), asadminOK());
+        }
     }
 
     @Test

nucleus/admin/launcher/src/main/java/com/sun/enterprise/admin/launcher/GFLauncher.java

@@ -211,6 +211,7 @@ public final void launch() throws GFLauncherException {
                 LOG.log(INFO, () -> "Debugging will be available on port " + debugPort + ".");
             }
         }
+        logCommandLine();
         try {
             startTime = System.currentTimeMillis();
             if (isFakeLaunch()) {
@@ -284,7 +285,6 @@ public void setup() throws GFLauncherException, MiniXmlParserException {
         setClasspath();
         initCommandLine();
         setJvmOptions();
-        logCommandLine();
 
         // if no <network-config> element, we need to upgrade this domain
         needsAutoUpgrade = !domainXML.hasNetworkConfig();

nucleus/admin/server-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/cli/LocalServerCommand.java

@@ -404,7 +404,7 @@ protected final String waitForStart(final Long oldPid, final ServerLifeSignCheck
         if (startTimeout != null && startTimeout.isNegative()) {
             throw new CommandException(reportPidFileIssue(pidFile));
         }
-        final Long pid = loadPid(getServerDirs().getPidFile());
+        final Long pid = pidFile.isFile() ? loadPid(pidFile) : null;
         if (pid == null) {
             throw new CommandException(reportPidFileIssue(pidFile));
         }

nucleus/admin/server-mgmt/src/main/java/com/sun/enterprise/admin/servermgmt/cli/StartServerHelper.java

@@ -277,14 +277,10 @@ public static List<HostAndPort> parseCustomEndpoints(String customEndpoints) thr
      * So we have to wait a bit.
      */
     private static void checkFreeDebugPort(Integer debugPort, Duration timeout, boolean terse) {
-        if (debugPort == null) {
+        if (debugPort == null || NetUtils.isPortFree(debugPort)) {
             return;
         }
-        final HostAndPort debugEndpoint = new HostAndPort("localhost", debugPort, false);
-        if (!ProcessUtils.isListening(debugEndpoint)) {
-            return;
-        }
-        ProcessUtils.waitWhileListening(debugEndpoint, timeout, !terse);
+        ProcessUtils.waitFor(() -> NetUtils.isPortFree(debugPort), Duration.ofSeconds(10L), terse);
     }
 
     private static void checkFreeAdminPorts(List<HostAndPort> endpoints) throws GFLauncherException {