-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vscode-trace-extension not working with latest trace-viewer depenencies #35
Labels
bug
Something isn't working
Comments
Using eclipse-cdt-cloud/tsp-typescript-client#56, the serialization / deserialization of BigInt values can be achieved when sending/receiving signals. |
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this issue
Sep 14, 2022
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This has to be addressed when deserializing messages. Re-use the normalizer of the tsp-typescript-client to do that. The following branch in the tps-typescript-client is introducing an utility class and, if accepted, it can be used to solve the deserialization issue: eclipse-cdt-cloud/tsp-typescript-client#56 Contributes to fixing eclipse-cdt-cloud#35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this issue
Sep 15, 2022
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This has to be addressed when deserializing messages. Re-use the normalizer of the tsp-typescript-client to do that. The following branch in the tps-typescript-client is introducing an utility class and, if accepted, it can be used to solve the deserialization issue: eclipse-cdt-cloud/tsp-typescript-client#56 Contributes to fixing eclipse-cdt-cloud#35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this issue
Sep 16, 2022
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This has to be addressed when deserializing messages. Re-use the normalizer of the tsp-typescript-client to do that. The following branch in the tps-typescript-client is introducing an utility class and, if accepted, it can be used to solve the deserialization issue: eclipse-cdt-cloud/tsp-typescript-client#56 Contributes to fixing eclipse-cdt-cloud#35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this issue
Sep 22, 2022
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This has to be addressed when deserializing messages. Re-use the normalizer of the tsp-typescript-client to do that. The following branch in the tps-typescript-client is introducing an utility class and, if accepted, it can be used to solve the deserialization issue: eclipse-cdt-cloud/tsp-typescript-client#56 Contributes to fixing eclipse-cdt-cloud#35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
that referenced
this issue
Sep 23, 2022
TODO: JSONBig.parse() doesn't create bigint if numbers are small. This has to be addressed when deserializing messages. Re-use the normalizer of the tsp-typescript-client to do that. The following branch in the tps-typescript-client is introducing an utility class and, if accepted, it can be used to solve the deserialization issue: eclipse-cdt-cloud/tsp-typescript-client#56 Contributes to fixing #35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
to bhufmann/vscode-trace-extension
that referenced
this issue
Sep 26, 2022
Contributes to fixing eclipse-cdt-cloud#35 Signed-off-by: Bernd Hufmann <[email protected]>
bhufmann
added a commit
that referenced
this issue
Sep 30, 2022
Contributes to fixing #35 Signed-off-by: Bernd Hufmann <[email protected]>
The extension works now with:
Serialization is fixed for experiments and it's not an issue for data provider descriptors. Closing this one and open a ticker for improved and more generic serialization implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the recent updates in the trace viewer components and its dependencies to use
BigInt
for timestamps, the serialization of messages between the webviews and vscode extension will fail because the standard json serializer doesn't support typeBigInt
.It will fail with the following message:
For example the
Experiment
orTrace
classes contain timestamp fields which areBigInt
and causing serialization problems and the vscode trace extension to fail.To fix this, each message send between webviews and the vscode trace extension itself need to be updated that
BigInt
values are serialized properly (e.g. using a string) and deserialized toBigInt
on the receiving side.This issue needs to be fixed before upgrading to the latest traceviewer components which contain many valuable improvements.
The text was updated successfully, but these errors were encountered: