Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nova 5.x support #452

Open
vbezruchkin opened this issue Dec 16, 2024 · 5 comments
Open

Nova 5.x support #452

vbezruchkin opened this issue Dec 16, 2024 · 5 comments

Comments

@vbezruchkin
Copy link

Hi guys,

Thanks for your packages. Any chance to get this updated to support Nova 5.x released a few days ago?

Thanks

@vipulasa
Copy link

You can manually clone it, change the composer nova version to 5, and use it. Remember you need to change a single function definition in advanced-nova-media-library/src/Fields/Media.php line 290 to public function resolve($resource, ?string $attribute = null): void

@maul75
Copy link

maul75 commented Dec 31, 2024

I think this small adjustment should be incorporated into the base repo. Unless this repository is no longer maintained, then a clone / fork makes more sense. Maybe there will be a short update from the developers.

@daPhantom
Copy link

Any update on Nova 5 compatibility? This is the only blocking dependency we have as of right now.

@daPhantom
Copy link

daPhantom commented Jan 2, 2025

You can manually clone it, change the composer nova version to 5, and use it. Remember you need to change a single function definition in advanced-nova-media-library/src/Fields/Media.php line 290 to public function resolve($resource, ?string $attribute = null): void

Looks like this is not sufficient. I forked it and I do not have any controls on the thumbnails like deleting images, downloading, etc... So it's not 100% functional as of right now.

The Nova 5 upgrade guide also mentions version bumps for inertia and the deprecation of form-backend-validation. Both are used as npm dependency.

@gerardnll
Copy link

gerardnll commented Jan 3, 2025

Correct. It needs changes on the JS side as @daPhantom says. Merged PR solves compatibility partially.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants