Skip to content

Commit f764813

Browse files
authored
Fix icons on Files field (#384)
* Fix icon on Files field * Fix clearfix and publish assets commit eb5b411 Author: Potsky <[email protected]> Date: Thu Mar 16 14:09:34 2023 +0100 Fix clearfix and publish assets
1 parent 721758f commit f764813

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

dist/js/field.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

readme.md

+11
Original file line numberDiff line numberDiff line change
@@ -322,3 +322,14 @@ Files::make('Multiple files', 'multiple_files')
322322
- Replaced [vuejs-clipper](https://www.npmjs.com/package/vuejs-clipper) with [vue-advanced-cropper](https://www.npmjs.com/package/vue-advanced-cropper) for vue3 support
323323

324324
Full change log in [PR #317](https://github.com/ebess/advanced-nova-media-library/pull/317)
325+
326+
# How to contribute
327+
328+
- You need to have Nova installed of course in your Laravel app
329+
- Work directly in the package in the `vendor` directory (webpack needs Nova to be installed)
330+
- Then from the `vendor/xxx/advanced-nova-media-library` folder:
331+
- `yarn install`
332+
- `yarn npm watch`
333+
- Work hard 🤘
334+
- `yarn npm production` when job is finished
335+
- Make a PR

resources/js/components/Gallery.vue

+5-10
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,9 @@
99
:configs="field.croppingConfigs"
1010
/>
1111

12-
<template v-if="draggable"
13-
14-
></template>
15-
16-
<draggable v-if="images.length > 0" v-model="images"
17-
class="gallery-list clearfix">
18-
12+
<draggable v-if="images.length > 0" v-model="images" class="gallery-list clearfix">
1913
<template #item="{element, index}">
20-
<div style="float:left;">
14+
<div style="float:left; margin-right: 1em;">
2115
<component :is="singleComponent" class="mb-3 p-3 mr-3"
2216
:key="index" :image="element" :field="field" :editable="editable" :removable="removable || editable" @remove="remove(index)"
2317
:is-custom-properties-editable="customProperties && customPropertiesFields.length > 0"
@@ -33,12 +27,13 @@
3327
/>
3428
</div>
3529
</template>
36-
3730
</draggable>
3831

3932
<span v-else-if="!editable" class="mr-3">&mdash;</span>
4033

41-
<span v-if="editable" class="form-file">
34+
<br style="clear: both" />
35+
36+
<span v-if="editable" class="">
4237
<input :id="`__media__${field.attribute}`" :multiple="multiple" ref="file" class="form-file-input" type="file" :disabled="uploading" @change="add"/>
4338
<label :for="`__media__${field.attribute}`" class="">
4439
<DefaultButton type="button" @click.prevent="focusFileInput">

resources/js/components/SingleFile.vue

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111
{{ image.file_name }}
1212
</span>
1313
<a v-if="isCustomPropertiesEditable" class="edit edit--file ml-2" href="#" @click.prevent="$emit('edit-custom-properties')">
14-
<icon type="edit" view-box="0 0 20 20" width="16" height="16" />
14+
<icon type="pencil" view-box="0 0 20 20" width="16" height="16" />
1515
</a>
1616
<a v-if="removable" class="delete ml-2" href="#" @click.prevent="$emit('remove')">
17-
<icon type="delete" view-box="0 0 20 20" width="16" height="16" />
17+
<icon type="trash" view-box="0 0 20 20" width="16" height="16" />
1818
</a>
1919
</div>
2020
</gallery-item>

0 commit comments

Comments
 (0)