Enhance the skip-extension test to cover modulename: False

There shouldn't be a command executed for that.

Author: Flamefire

test/framework/easyblock.py

@@ -1190,7 +1190,7 @@ def test_skip_extensions_step(self):
                 "ext1",
                 ("EXT-2", "42", {"source_tmpl": "dummy.tgz"}),
                 ("ext3", "1.1", {"source_tmpl": "dummy.tgz", "modulename": "real_ext"}),
-                "ext4",
+                ("ext4", "0.2", {"source_tmpl": "dummy.tgz", "modulename": False}),
             ]
             exts_filter = ("\
                 if [ %(ext_name)s == 'ext_2' ] && [ %(ext_version)s == '42' ] && [[ %(src)s == *dummy.tgz ]];\
@@ -1206,20 +1206,24 @@ def test_skip_extensions_step(self):
         eb.installdir = config.install_path()
         eb.skip = True
 
-        self.mock_stdout(True)
-        eb.extensions_step(fetch=True)
-        stdout = self.get_stdout()
-        self.mock_stdout(False)
+        with self.mocked_stdout_stderr():
+            eb.extensions_step(fetch=True)
+            stdout = self.get_stdout()
+        logtxt = read_file(eb.logfile)
+        self.assertRegex(logtxt, r"Running shell command\W+if \[ ext1")
+        self.assertRegex(logtxt, r"Running shell command\W+if \[ ext_2")
+        self.assertRegex(logtxt, r"Running shell command\W+if \[ real_ext")
+        # modulename: False skips the check
+        self.assertNotRegex(logtxt, r"Running shell command\W+if \[ (False|ext4)")
 
         patterns = [
             r"^== skipping extension EXT-2",
             r"^== skipping extension ext3",
             r"^== installing extension ext1  \(1/2\)\.\.\.",
-            r"^== installing extension ext4  \(2/2\)\.\.\.",
+            r"^== installing extension ext4 0.2 \(2/2\)\.\.\.",
         ]
         for pattern in patterns:
-            regex = re.compile(pattern, re.M)
-            self.assertTrue(regex.search(stdout), "Pattern '%s' found in: %s" % (regex.pattern, stdout))
+            self.assertRegex(stdout, re.compile(pattern, re.M))
 
         # 'ext1' should be in eb.ext_instances
         eb_exts = [x.name for x in eb.ext_instances]