vuln-fix: Zip Slip Vulnerability (#13)

This fixes a Zip-Slip vulnerability.

This change does one of two things. This change either

1. Inserts a guard to protect against Zip Slip.
OR
2. Replaces `dir.getCanonicalPath().startsWith(parent.getCanonicalPath())`, which is vulnerable to partial path traversal attacks, with the more secure `dir.getCanonicalFile().toPath().startsWith(parent.getCanonicalFile().toPath())`.

For number 2, consider `"/usr/outnot".startsWith("/usr/out")`.
The check is bypassed although `/outnot` is not under the `/out` directory.
It's important to understand that the terminating slash may be removed when using various `String` representations of the `File` object.
For example, on Linux, `println(new File("/var"))` will print `/var`, but `println(new File("/var", "/")` will print `/var/`;
however, `println(new File("/var", "/").getCanonicalPath())` will print `/var`.

Weakness: CWE-22: Improper Limitation of a Pathname to a Restricted Directory ('Path Traversal')
Severity: High
CVSSS: 7.4
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-zipslip/) & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.ZipSlip)

Reported-by: Jonathan Leitschuh <[email protected]>
Signed-off-by: Jonathan Leitschuh <[email protected]>

Bug-tracker: JLLeitschuh/security-research#16


Co-authored-by: Moderne <[email protected]>

Co-authored-by: Moderne <[email protected]>

Author: JLLeitschuh

build-service/src/main/java/com/ccoe/build/utils/CompressUtils.java

@@ -114,8 +114,10 @@ public static List<File> unCompress(File zip, String unzipdir) throws IOExceptio
 				System.out.println("Extracting: " + entry);
 				int count;
 				byte data[] = new byte[BUFFER];
-				File unzipfile = new File(unzipdir + File.separator
-						+ entry.getName());
+				File unzipfile = new File(unzipdir, entry.getName());
+				if (!unzipfile.toPath().normalize().startsWith(unzipdir)) {
+					throw new IOException("Bad zip entry");
+				}
 				FileOutputStream fos = new FileOutputStream(unzipfile);
 				BufferedOutputStream dest = new BufferedOutputStream(fos, BUFFER);