Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #2

Open
ghost opened this issue Aug 22, 2019 · 9 comments
Open

Python 3 support #2

ghost opened this issue Aug 22, 2019 · 9 comments

Comments

@ghost
Copy link

ghost commented Aug 22, 2019

Given python 2 support ceases on 01/01/2020, just 4 months away at the time of writing, it seems odd to have chosen to support python 2 at all let alone solely. It would be great to port this over to python 3.

@cwcatherine
Copy link
Contributor

@spelga Thank you for your comment. Completely agree. I would like to have this be in Python 3 but do not currently have the bandwidth to do the conversion. Given this is as an open source project, anyone is welcome to port this to 3. Thank you.

@Johennes
Copy link

Johennes commented Sep 1, 2019

I think the code actually is compatible with Python 3. At least I'm able to run the tests using Python 3 after fixing the print ... statements to print(...) in the test files. I didn't have to make any changes to the actual code.

@brooketalcott
Copy link

This is a fairly new repository, @cwcatherine, is backwards python compatibility a concern? I have a successful test with minimal changes here master...brooketalcott:python3 (3.6+)

3.5 is EOL in September 2020

Happy to open a PR if this is acceptable

@carlcrott
Copy link

Does someone have a working example of this "OAuth2 Flow" I would like to post to createItemDraft and the process is kind of obnoxious, to the point where I've started paying ebay to give me working examples lol

Does anyone happen to have this working with:

@sanidhyaagrawal
Copy link

@carlcrott did you find examples for-

createItemDraft
OAuth2
Scope: https://api.ebay.com/oauth/api_scope/sell.item.draft

as you mentioned above? I am working on something similar, would be a great help if you can provide?

@umarsear
Copy link

umarsear commented Mar 2, 2022

This is a fairly new repository, @cwcatherine, is backwards python compatibility a concern? I have a successful test with minimal changes here master...brooketalcott:python3 (3.6+)

3.5 is EOL in September 2020

Happy to open a PR if this is acceptable

Was helpful for me, thanks.

@matecsaj
Copy link

matecsaj commented Mar 2, 2022

You are welcome to harvest bits from here
https://github.com/matecsaj/ebay_rest/blob/main/src/ebay_rest/token.py

or use the whole library.
https://github.com/matecsaj/ebay_rest

@umarsear
Copy link

umarsear commented Mar 3, 2022

Thanks,

I am struggling a little with how to use the Rest-API. I was hoping to be able to keep the token minting and the API implementations separate. I can't see how I can make an API call with an existing access-token.

I already have a working solution to mint tokens (plan to extend it to be used by multiple applications) and want to be able to call, say the fulfillment API to get orders, but can't figure out how to construct the call and pass in the token and other parameters.

@matecsaj
Copy link

matecsaj commented Mar 3, 2022

Please clarify, are you struggling to:

  1. use something like the Python Requests library to make the RESTful API call
  2. use Swagger-generated API code
  3. use the ebay-rest pip library that I made
  4. or something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants