v4.x - Remove folly::Expected from API.

[szmyd]

No description provided.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 36.06557% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.04%. Comparing base (1746bcc) to head (da3ef58).
⚠️ Report is 135 commits behind head on main.

Files with missing lines	Patch %	Lines
src/lib/homestore_backend/hs_blob_manager.cpp	20.00%	25 Missing and 3 partials ⚠️
src/lib/homestore_backend/hs_shard_manager.cpp	4.54%	19 Missing and 2 partials ⚠️
src/lib/homestore_backend/hs_pg_manager.cpp	50.00%	10 Missing and 1 partial ⚠️
...ib/homestore_backend/replication_state_machine.cpp	0.00%	4 Missing ⚠️
src/lib/blob_manager.cpp	66.66%	0 Missing and 3 partials ⚠️
src/lib/homestore_backend/pg_blob_iterator.cpp	0.00%	2 Missing and 1 partial ⚠️
...lib/homestore_backend/snapshot_receive_handler.cpp	0.00%	1 Missing and 1 partial ⚠️
src/lib/memory_backend/mem_pg_manager.cpp	66.66%	2 Missing ⚠️
src/lib/homestore_backend/index_kv.cpp	66.66%	1 Missing ⚠️
src/lib/memory_backend/mem_shard_manager.cpp	0.00%	0 Missing and 1 partial ⚠️
... and 2 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #362      +/-   ##
==========================================
- Coverage   63.15%   57.04%   -6.11%     
==========================================
  Files          32       35       +3     
  Lines        1900     4568    +2668     
  Branches      204      565     +361     
==========================================
+ Hits         1200     2606    +1406     
- Misses        600     1685    +1085     
- Partials      100      277     +177     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[JacksonYao287]

LGTM

[JacksonYao287]

@yuwmao pls take a look. do we need any changes in SM side to adapt to this interface change?

[xiaoxichen]

@szmyd could we rebase this and trageting to the v4 branch ? we are introducing some of the incompatibility changes there.

[yuwmao]

@yuwmao pls take a look. do we need any changes in SM side to adapt to this interface change?

Sorry, I missed the comment, will take a look.

[szmyd]

I'm closing this for now as there are too many things in flight, will re-introduce later.