Skip to content

Commit c5a1d2b

Browse files
authored
Merge pull request #26 from dwickern/improve-docs
Improve docs
2 parents eea5c6e + 6c23656 commit c5a1d2b

File tree

7 files changed

+75
-22
lines changed

7 files changed

+75
-22
lines changed

README.md

+8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,14 @@ Usage
2626

2727
[View the docs here](https://dwickern.github.io/ember-basic-tree/).
2828

29+
```hbs
30+
<BasicTree as |tree|>
31+
<tree.Node @content="ember" @isExpanded={{true}}>
32+
<tree.Node @content="basic"/>
33+
<tree.Node @content="tree"/>
34+
</tree.Node>
35+
</BasicTree>
36+
```
2937

3038
Contributing
3139
------------------------------------------------------------------------------

package.json

+3
Original file line numberDiff line numberDiff line change
@@ -62,9 +62,12 @@
6262
"ember-cli-inject-live-reload": "^2.1.0",
6363
"ember-cli-sri": "^2.1.1",
6464
"ember-cli-terser": "^4.0.2",
65+
"ember-click-outside": "^2.0.0",
6566
"ember-concurrency": "^2.2.0",
67+
"ember-concurrency-decorators": "^2.0.3",
6668
"ember-data": "^3.24.0",
6769
"ember-disable-prototype-extensions": "^1.1.3",
70+
"ember-event-helpers": "^0.1.1",
6871
"ember-export-application-global": "^2.0.1",
6972
"ember-load-initializers": "^2.1.2",
7073
"ember-maybe-import-regenerator": "^0.1.6",

tests/dummy/app/components/context-menu-example/content.hbs

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
{{! BEGIN-SNIPPET context-menu-content.hbs }}
22
<BasicDropdown as |dd|>
3-
<dd.Trigger {{on "contextmenu" (fn this.openContextMenu dd)}}>
3+
<dd.Trigger {{on "contextmenu" (prevent-default dd.actions.open)}}>
44
{{@node.content}}
55
</dd.Trigger>
6-
<dd.Content class="context-menu-example--dropdown-content">
6+
<dd.Content
7+
class="context-menu-example--dropdown-content"
8+
{{on-click-outside dd.actions.close eventType="contextmenu"}}
9+
>
710
{{#if @node.menuComponent}}
8-
{{component @node.menuComponent}}
11+
<@node.menuComponent/>
912
{{else}}
1013
{{@node.menuText}}
1114
{{/if}}

tests/dummy/app/components/context-menu-example/content.js

-12
This file was deleted.

tests/dummy/app/components/custom-children-js/index.js

+5-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// BEGIN-SNIPPET custom-children-js-index.js
22
import Component from '@glimmer/component';
3-
import { task, timeout } from 'ember-concurrency';
3+
import { task } from 'ember-concurrency-decorators';
4+
import { timeout } from 'ember-concurrency';
45

56
class Node {
67
constructor(counter, more) {
@@ -16,16 +17,16 @@ class Node {
1617
}
1718

1819
export default class extends Component {
19-
@task(function* () {
20+
@task
21+
*loadMore() {
2022
yield timeout(1000);
2123

2224
const nodes = [];
2325
for (let i = 0; i < 3; ++i) {
2426
nodes.push(this.generateNode());
2527
}
2628
return nodes;
27-
})
28-
loadMore;
29+
}
2930

3031
counter = 0;
3132

tests/dummy/app/components/demo-context-menu.hbs

-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,5 @@
44
</demo.example>
55
<demo.snippet @name="context-menu-example.hbs"/>
66
<demo.snippet @label="content.hbs" @name="context-menu-content.hbs"/>
7-
<demo.snippet @label="content.js" @name="context-menu-content.js"/>
87
<demo.snippet @label="custom-menu.hbs" @name="context-menu-custom-menu.hbs"/>
98
</DocsDemo>

yarn.lock

+53-2
Original file line numberDiff line numberDiff line change
@@ -1204,7 +1204,7 @@
12041204
"@ember-decorators/utils" "^6.1.1"
12051205
ember-cli-babel "^7.1.3"
12061206

1207-
"@ember-decorators/utils@^6.1.1":
1207+
"@ember-decorators/utils@^6.1.0", "@ember-decorators/utils@^6.1.1":
12081208
version "6.1.1"
12091209
resolved "https://registry.yarnpkg.com/@ember-decorators/utils/-/utils-6.1.1.tgz#6b619814942b4fb3747cfa9f540c9f05283d7c5e"
12101210
integrity sha512-0KqnoeoLKb6AyoSU65TRF5T85wmS4uDn06oARddwNPxxf/lt5jQlh41uX3W7V/fWL9tPu8x1L1Vvpc80MN1+YA==
@@ -3219,6 +3219,11 @@ babel-plugin-filter-imports@^4.0.0:
32193219
"@babel/types" "^7.7.2"
32203220
lodash "^4.17.15"
32213221

3222+
babel-plugin-htmlbars-inline-precompile@^3.2.0:
3223+
version "3.2.0"
3224+
resolved "https://registry.yarnpkg.com/babel-plugin-htmlbars-inline-precompile/-/babel-plugin-htmlbars-inline-precompile-3.2.0.tgz#c4882ea875d0f5683f0d91c1f72e29a4f14b5606"
3225+
integrity sha512-IUeZmgs9tMUGXYu1vfke5I18yYJFldFGdNFQOWslXTnDWXzpwPih7QFduUqvT+awDpDuNtXpdt5JAf43Q1Hhzg==
3226+
32223227
babel-plugin-htmlbars-inline-precompile@^4.2.0:
32233228
version "4.4.6"
32243229
resolved "https://registry.yarnpkg.com/babel-plugin-htmlbars-inline-precompile/-/babel-plugin-htmlbars-inline-precompile-4.4.6.tgz#9fd632ad2717226b90bde6940b4148b3a323fddb"
@@ -4400,7 +4405,7 @@ broccoli-plugin@^2.0.0, broccoli-plugin@^2.1.0:
44004405
rimraf "^2.3.4"
44014406
symlink-or-copy "^1.1.8"
44024407

4403-
broccoli-plugin@^3.0.0:
4408+
broccoli-plugin@^3.0.0, broccoli-plugin@^3.1.0:
44044409
version "3.1.0"
44054410
resolved "https://registry.yarnpkg.com/broccoli-plugin/-/broccoli-plugin-3.1.0.tgz#54ba6dd90a42ec3db5624063292610e326b1e542"
44064411
integrity sha512-7w7FP8WJYjLvb0eaw27LO678TGGaom++49O1VYIuzjhXjK5kn2+AMlDm7CaUFw4F7CLGoVQeZ84d8gICMJa4lA==
@@ -6581,6 +6586,26 @@ ember-cli-htmlbars@^3.0.1:
65816586
json-stable-stringify "^1.0.1"
65826587
strip-bom "^3.0.0"
65836588

6589+
ember-cli-htmlbars@^4.2.3, ember-cli-htmlbars@^4.3.1:
6590+
version "4.5.0"
6591+
resolved "https://registry.yarnpkg.com/ember-cli-htmlbars/-/ember-cli-htmlbars-4.5.0.tgz#d299e4f7eba6f30dc723ee086906cc550beb252e"
6592+
integrity sha512-bYJpK1pqFu9AadDAGTw05g2LMNzY8xTCIqQm7dMJmKEoUpLRFbPf4SfHXrktzDh7Q5iggl6Skzf1M0bPlIxARw==
6593+
dependencies:
6594+
"@ember/edition-utils" "^1.2.0"
6595+
babel-plugin-htmlbars-inline-precompile "^3.2.0"
6596+
broccoli-debug "^0.6.5"
6597+
broccoli-persistent-filter "^2.3.1"
6598+
broccoli-plugin "^3.1.0"
6599+
common-tags "^1.8.0"
6600+
ember-cli-babel-plugin-helpers "^1.1.0"
6601+
fs-tree-diff "^2.0.1"
6602+
hash-for-dep "^1.5.1"
6603+
heimdalljs-logger "^0.1.10"
6604+
json-stable-stringify "^1.0.1"
6605+
semver "^6.3.0"
6606+
strip-bom "^4.0.0"
6607+
walk-sync "^2.0.2"
6608+
65846609
ember-cli-htmlbars@^5.0.0:
65856610
version "5.3.1"
65866611
resolved "https://registry.yarnpkg.com/ember-cli-htmlbars/-/ember-cli-htmlbars-5.3.1.tgz#61793964fc2599ce750db9e972ab55c6dd177c48"
@@ -6951,6 +6976,15 @@ ember-cli@~3.28.4:
69516976
workerpool "^6.1.4"
69526977
yam "^1.0.0"
69536978

6979+
ember-click-outside@^2.0.0:
6980+
version "2.0.0"
6981+
resolved "https://registry.yarnpkg.com/ember-click-outside/-/ember-click-outside-2.0.0.tgz#4b056a1f737ed2b2c933b05fff7b3501c967cd8f"
6982+
integrity sha512-d53L+Of9rRhB8RU32xKFDG58e8MJZRPFF9HAuUIcn3Hl5U7v8Gb9YqB59khcryCkRXWzLOvVgmNFjNaV9iZJyQ==
6983+
dependencies:
6984+
ember-cli-babel "^7.18.0"
6985+
ember-cli-htmlbars "^4.2.3"
6986+
ember-modifier "^2.1.0"
6987+
69546988
ember-code-snippet@^3.0.0:
69556989
version "3.0.0"
69566990
resolved "https://registry.yarnpkg.com/ember-code-snippet/-/ember-code-snippet-3.0.0.tgz#5e3108a68cc76740355cbbca840656d96c6b7ba1"
@@ -6984,6 +7018,16 @@ ember-composable-helpers@^4.4.1:
69847018
ember-cli-babel "^7.11.1"
69857019
resolve "^1.10.0"
69867020

7021+
ember-concurrency-decorators@^2.0.3:
7022+
version "2.0.3"
7023+
resolved "https://registry.yarnpkg.com/ember-concurrency-decorators/-/ember-concurrency-decorators-2.0.3.tgz#2816c9a0283b90ba5340fc5b4e0b92ea91f7d6e3"
7024+
integrity sha512-r6O34YKI/slyYapVsuOPnmaKC4AsmBSwvgcadbdy+jHNj+mnryXPkm+3hhhRnFdlsKUKdEuXvl43lhjhYRLhhA==
7025+
dependencies:
7026+
"@ember-decorators/utils" "^6.1.0"
7027+
ember-cli-babel "^7.19.0"
7028+
ember-cli-htmlbars "^4.3.1"
7029+
ember-cli-typescript "^3.1.4"
7030+
69877031
ember-concurrency@^2.0.0, ember-concurrency@^2.1.2, ember-concurrency@^2.2.0:
69887032
version "2.2.0"
69897033
resolved "https://registry.yarnpkg.com/ember-concurrency/-/ember-concurrency-2.2.0.tgz#0acfb8ca855e0fdfa4c543be150028299a89ba32"
@@ -7047,6 +7091,13 @@ ember-element-helper@^0.5.0, ember-element-helper@^0.5.5:
70477091
ember-cli-babel "^7.17.2"
70487092
ember-cli-htmlbars "^5.1.0"
70497093

7094+
ember-event-helpers@^0.1.1:
7095+
version "0.1.1"
7096+
resolved "https://registry.yarnpkg.com/ember-event-helpers/-/ember-event-helpers-0.1.1.tgz#8df141306c927b9d1a7bc63d63095e92c0ba90a1"
7097+
integrity sha512-fWcbWd4W4nRv8bbato8JB6oGRpATkR+oGYxMIqnfgTgPWaCS0ww7CuUVNpwg1TulojKMCuTXi8Fem2b1NSF1ZQ==
7098+
dependencies:
7099+
ember-cli-babel "^7.19.0"
7100+
70507101
ember-export-application-global@^2.0.1:
70517102
version "2.0.1"
70527103
resolved "https://registry.yarnpkg.com/ember-export-application-global/-/ember-export-application-global-2.0.1.tgz#b120a70e322ab208defc9e2daebe8d0dfc2dcd46"

0 commit comments

Comments
 (0)