Ensure we are following the PSR coding standards

Author: duncan3dc

.travis.yml

@@ -28,6 +28,10 @@ jobs:
       script:
         - vendor/bin/composer-require-checker --config-file=.require.json
 
+    - stage: coding standards
+      script:
+        - vendor/bin/phpcs --standard=phpcs.xml src tests
+
     - stage: coverage
       script:
         - vendor/bin/phpunit --coverage-clover=coverage.xml

composer.json

@@ -19,6 +19,7 @@
     "require-dev": {
         "maglnet/composer-require-checker": "^1.1",
         "mockery/mockery": "^1.2",
+        "squizlabs/php_codesniffer": "^3.3.2",
         "phpunit/phpunit": "^7.5"
     },
     "suggest": {

phpcs.xml

@@ -0,0 +1,12 @@
+<?xml version="1.0"?>
+<ruleset name="duncan3dc">
+
+    <rule ref="PSR1" />
+    <rule ref="PSR2" />
+    <rule ref="PSR12" />
+
+    <rule ref="Generic.Files.LineLength">
+        <severity>0</severity>
+    </rule>
+
+</ruleset>

src/Providers/AbstractProvider.php

@@ -39,7 +39,7 @@ public function setClient(ClientInterface $client): ProviderInterface
     public function getClient(): ClientInterface
     {
         if ($this->client === null) {
-            $this->client = new Client;
+            $this->client = new Client();
         }
 
         return $this->client;

src/Providers/PicottsProvider.php

@@ -126,7 +126,7 @@ public function textToSpeech(string $text, ProcessBuilder $builder = null): stri
         }
 
         if ($builder === null) {
-            $builder = new ProcessBuilder;
+            $builder = new ProcessBuilder();
         }
 
         $process = $builder

tests/Providers/AbstractProviderTest.php

@@ -16,7 +16,7 @@ class AbstractProviderTest extends TestCase
     public function setUp()
     {
         $this->client = Mockery::mock(ClientInterface::class);
-        $this->provider = new ExampleProvider;
+        $this->provider = new ExampleProvider();
         $this->provider->setClient($this->client);
     }
 
@@ -41,7 +41,7 @@ public function testGetOptions()
 
     public function testGetClient()
     {
-        $provider = new ExampleProvider;
+        $provider = new ExampleProvider();
         $this->assertInstanceOf(ClientInterface::class, $provider->getClient());
     }
 

tests/Providers/GoogleProviderTest.php

@@ -16,7 +16,7 @@ class GoogleProviderTest extends TestCase
 
     public function setUp()
     {
-        $this->provider = new GoogleProvider;
+        $this->provider = new GoogleProvider();
 
         $this->client = Mockery::mock(ClientInterface::class);
         $this->provider->setClient($this->client);

tests/Providers/PicottsProviderTest.php

@@ -24,7 +24,7 @@ public function setUp()
             return $this->binary;
         });
 
-        $this->provider = new PicottsProvider;
+        $this->provider = new PicottsProvider();
     }
 
 
@@ -44,7 +44,7 @@ public function testBinaryInstalled()
 
         $this->expectException(ProviderException::class);
         $this->expectExceptionMessage("Unable to find picotts program, please install pico2wave before trying again");
-        $provider = new PicottsProvider;
+        $provider = new PicottsProvider();
     }
 
 

tests/Providers/ResponsiveVoiceProviderTest.php

@@ -16,7 +16,7 @@ class ResponsiveVoiceProviderTest extends TestCase
 
     public function setUp()
     {
-        $this->provider = new ResponsiveVoiceProvider;
+        $this->provider = new ResponsiveVoiceProvider();
 
         $this->client = Mockery::mock(ClientInterface::class);
         $this->provider->setClient($this->client);