Always take the global lock when using PostgresFunctionGuard #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
added a commit
that referenced
this pull request
Feb 13, 2025
JelteF
force-pushed
the
more-careful-locking
branch
from
d100656 to
1b5b82f
Compare
JelteF
changed the title
Makes our lives a lot easier by making sure we cannot run into self-deadlocks anymore. This allows us to be a lot more liberal with sprinkling this lock around, which makes it a lot more easy to write thread safe code.
JelteF
force-pushed
the
more-careful-locking
branch
from
1b5b82f to
eb40e2f
Compare
Y--
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some really confusing segfaults that were still occurring even after #584. Reverting #584 (while keeping this change) re-introduces other segfaults. So both fixes are necessary.