Print function name rather than caller #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Y--
commented
Feb 12, 2025
Y--
force-pushed
the
yl/improve-wrappers
branch
3 times, most recently
from
e743937 to
3dd86ad
Compare
When an error is raised
Y--
force-pushed
the
yl/improve-wrappers
branch
from
3dd86ad to
40a7bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an error is raised, we used to print the
__func__string, which contains the current function name where the macro is placed, hence the actual "caller" of the function being wrapped.This PR replaces the caller name with the name of the function being wrapped.
In an initial version I was displaying both, but found it to be redundant.
An alternative would be to check if caller name contains the function name (or vice-versa) which happens often when we have functions such as
TopLevelFuncandTopLevelFunc_cpp, and:But that sounds a bit much.
Happy to hear some feedback :-)