Add test that runs DuckDB its test_all_types function #577
Conversation
| smallint | -32768 | ||
| int | -2147483648 | ||
| bigint | -9223372036854775808 | ||
| hugeint | 0 |
There was a problem hiding this comment.
This is a bug! We should be returning:
| hugeint | 0 | |
| hugeint | -170141183460469231731687303715884105728 |
| $$) | ||
| -[ RECORD 1 ]---+------------------------------------------------------------------------------------------------------------------------------------- | ||
| bool | f | ||
| tinyint | \200 |
There was a problem hiding this comment.
This is displayed pretty weirdly. Maybe we should not use the char type for this, but instead upscale to a regular int. For now I added this as a limitation to the #575 PR.
| date | 07-14-5881580 | ||
| timestamp | Sun Jan 10 08:01:49.551616 294247 | ||
| timestamp_s | Sun Jan 10 08:01:49.551616 294247 | ||
| timestamp_ms | Sun Jan 10 08:01:49.551616 294247 | ||
| timestamp_ns | Wed Sep 22 00:00:00 1677 | ||
| timestamp_tz | Sun Jan 10 00:01:49.551616 294247 PST |
There was a problem hiding this comment.
All of these underflow currently. I think we should either truncate or throw an error in this case.
| blob | \000\000\000a | ||
| int_array | {42,999,NULL,NULL,-42} | ||
| double_array | {42,NaN,Infinity,-Infinity,NULL,-42} | ||
| date_array | {01-01-1970,07-11-5881580,07-13-5881580,NULL,05-12-2022} |
There was a problem hiding this comment.
the two dates in the middle are displayed by duckdb as infinity and -infinity, same for the timestamp_array below. Would be worth looking into what is up with those.
There was a problem hiding this comment.
Turns out infinity and -infinity are valid values for dates/timestamps in both Postgres and DuckDB. But based on this our conversion of these is lacking.
JelteF
force-pushed
the
test-all-types-duckdb
branch
from
0ccb600 to
18b655d
Compare
JelteF
force-pushed
the
test-all-types-duckdb
branch
from
b259a10 to
f7371be
Compare
This is an easy way to test conversion from Postgres to DuckDB for types that don't have an equivalent in Postgres. It also gives us an easy todo list of types that we don't support yet.
JelteF
force-pushed
the
test-all-types-duckdb
branch
from
f7371be to
ba4fc36
Compare
This is an easy way to test conversion from Postgres to DuckDB for types
that don't have an equivalent in Postgres.
It also gives us an easy todo list of types that we don't support yet.