Raised in review of #28: after that PR, pnpm test runs the schema-digest drift check, the coverage assertions, and the vendored-artifact pins — but nothing automated runs pnpm test. The repo has no .github/workflows/ (the only checks on PRs are org-level CodeQL default setup), so every guard added in #28 holds only when a human runs the suite locally.
Suggested work
A small workflow (PR + push to main) that runs, from skill-harness/:
pnpm install --frozen-lockfile- the unit suite (
node --import tsx --test 'src/__tests__/**/*.test.ts' until pnpm test works again)
biome check --error-on-warnings and tsc --noEmitnode scripts/generate-schema-digest.mjs --check from the repo root (also covered by the suite, but a named check line is worth having)
Prerequisite: #30. pnpm install --frozen-lockfile currently fails on pnpm 11 (overrides placement), and a CI that installs unfrozen defeats part of the point. Fix #30 first or in the same PR, then wire the workflow.
Explicitly out of scope: the Tier-2 bench (pnpm bench) — it calls a model API and needs a key + cost decision; the workflow should run the offline suite only.
Once green, update README.md / CLAUDE.md wording from "pnpm test is what enforces it" to point at the workflow.
Raised in review of #28: after that PR,
pnpm testruns the schema-digest drift check, the coverage assertions, and the vendored-artifact pins — but nothing automated runspnpm test. The repo has no.github/workflows/(the only checks on PRs are org-level CodeQL default setup), so every guard added in #28 holds only when a human runs the suite locally.Suggested work
A small workflow (PR + push to main) that runs, from
skill-harness/:pnpm install --frozen-lockfilenode --import tsx --test 'src/__tests__/**/*.test.ts'untilpnpm testworks again)biome check --error-on-warningsandtsc --noEmitnode scripts/generate-schema-digest.mjs --checkfrom the repo root (also covered by the suite, but a named check line is worth having)Prerequisite: #30.
pnpm install --frozen-lockfilecurrently fails on pnpm 11 (overridesplacement), and a CI that installs unfrozen defeats part of the point. Fix #30 first or in the same PR, then wire the workflow.Explicitly out of scope: the Tier-2 bench (
pnpm bench) — it calls a model API and needs a key + cost decision; the workflow should run the offline suite only.Once green, update
README.md/CLAUDE.mdwording from "pnpm test is what enforces it" to point at the workflow.