Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JOSS review] Unused test file #2

Closed
rcaneill opened this issue Mar 28, 2025 · 2 comments
Closed

[JOSS review] Unused test file #2

rcaneill opened this issue Mar 28, 2025 · 2 comments

Comments

@rcaneill
Copy link
Contributor

Hi,

Romain (@rcaneill), one of your reviewer for the JOSS submission here.

It seems to me that this file is not used in the tests. Is it an old file that you forgot to remove?

#! /usr/bin/env python
# -*- coding: utf-8 -*-
# vim:fenc=utf-8
import os
ROOT = os.path.dirname(os.path.abspath(__file__))
print(ROOT)

openjournals/joss-reviews#7942

@rcaneill rcaneill changed the title [JOSS review] [JOSS review] Unused test file Mar 28, 2025
@rcaneill
Copy link
Contributor Author

Do you want me to open a PR for this?

@dspelaez
Copy link
Owner

dspelaez commented Apr 7, 2025

File was removed

@dspelaez dspelaez closed this as completed Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants