Skip to content

Conversation

@odiak
Copy link
Contributor

@odiak odiak commented May 10, 2023

While I investigating #1409, I found suspicious code from stack trace.
Because it works as expected after fixing there, I made this pull request.

@odiak odiak force-pushed the fix-manipulation branch from fb85107 to 03e2484 Compare May 10, 2023 08:03
@odiak
Copy link
Contributor Author

odiak commented May 10, 2023

I also found some similar code pieces, though I'm not sure if they cause error.

while (!currentNodeChildren.done)
this.straightReplace(currentNodeChildren.next(), newNodeChildren.next(), newSourceFile);

while (!currentChildren.done)
this.helper.handleForValues(this.straightReplacementNodeHandler, currentChildren.next(), newChildren.next(), newSourceFile);

while (!currentChildren.done)
this.helper.handleForValues(this.straightReplacementNodeHandler, currentChildren.next(), newChildren.next(), newSourceFile);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant