Issue #369 - Upgrade drupal/transliterate_filenames to 2.x

Author: Sweetchuck

composer.json

@@ -81,7 +81,7 @@
         "drupal/shield": "^1.4",
         "drupal/string_field_formatter": "^2.0",
         "drupal/svg_image": "^1.15",
-        "drupal/transliterate_filenames": "^1.5",
+        "drupal/transliterate_filenames": "^2.0",
         "drupal/webp": "^1.0@beta",
         "drush/drush": "^11.0",
         "oomphinc/composer-installers-extender": "^2.0"

composer.lock

@@ -22,6 +22,7 @@ default:
         - '\Sweetchuck\DrupalTestTraits\Core\Behat\Context\User'
         - '\Sweetchuck\DrupalTestTraits\EntityLegal\Behat\Context\EntityLegal'
         - '\DrupalHu\DrupalHu\Tests\Behat\Context\ExternalTranslations'
+        - '\DrupalHu\DrupalHu\Tests\Behat\Context\Browser'
 #        - '\Cheppers\DrupalExtension\Context\Drupal\Core'
 #        - '\Cheppers\DrupalExtension\Context\Drupal\CoreAjax'
 #        - '\Cheppers\DrupalExtension\Context\Drupal\CoreCache'

tests/behat/config/suite.default.yml

@@ -0,0 +1,13 @@
+@api
+@javascript
+Feature: Page node access create
+
+  Scenario Outline: node:page access:create with different roles
+    Given I am acting as a user with the "<role>" roles
+    When I go to "/node/add/page"
+    Then the response status code should be <status_code>
+    Examples:
+      | role          | status_code |
+      | anonymous     | 403         |
+      | authenticated | 403         |
+      | administrator | 200         |

tests/behat/features/page/page.node.access.create.feature

@@ -0,0 +1,58 @@
+@api
+@javascript
+#noinspection NonAsciiCharacters
+Feature: node:page create
+
+  Background:
+    Given users:
+      | name    | mail                    | roles         |
+      | dummy-1 | dummy-1@behat.localhost | administrator |
+    And I am logged in as "dummy-1"
+    And I am at "/node/add/page"
+
+  Scenario: Page node create – required field messages
+    Given required attributes are removed from all input elements in form "node-page-form"
+    And I press "Mentés"
+    Then I should see 1 message
+    Then I should see only the following error messages:
+      | Cím mező szükséges. |
+
+  Scenario: Page node create – only required fields
+    When I fill in "Cím" with "My page 01"
+    And I press "Mentés"
+    Then I should see 1 message
+    And I should see only the following status message:
+      | My page 01 Oldal létrejött. |
+
+  @transliterate
+  Scenario: Page node create – all fields
+    When I fill in "Cím" with "My page 01"
+
+    And I open the media library browser of the "Kép" media field
+    And I attach the file "behat-01-1440x1080.jpg" to "files[upload]"
+    And I wait for AJAX to finish
+    And I fill in "media[0][fields][field_media_image][0][alt]" with "My alt text"
+    And I press the "Mentés" action button in the "Média hozzáadása vagy kiválasztása" dialog
+    And I press the "Kijelölt beillesztése" action button in the "Média hozzáadása vagy kiválasztása" dialog
+
+    And I fill in wysiwyg on field "app_body[0][value]" with "My body text"
+
+    # @todo File attach does not work at normal speed. It works with XDebug step debugger.
+    # I have spent a lot of time to debugging, but still no clue what the problem is.
+    # I narrowed down the problem to \DMore\ChromeDriver\ChromeDriver::attachFile()
+    # $this->page->send().
+    # But maybe there is a problem with the "I fill in wysiwyg on field ..." step.
+    # The "I wait for AJAX to finish" step doesn't solve the problem.
+    And I wait 2 seconds
+    And I attach the file "árvíztűrő tükörfúrógép-lower.pdf" to "files[app_attachments_0][]"
+    And I wait for AJAX to finish
+    And I attach the file "ÁRVÍZTŰRŐ TÜKÖRFÚRÓGÉP-upper.pdf" to "files[app_attachments_1][]"
+    And I wait for AJAX to finish
+
+    And I press "Mentés"
+
+    Then I should see 1 message
+    And I should see only the following status message:
+      | My page 01 Oldal létrejött. |
+    And I should see the text "arvizturo-tukorfurogep-lower"
+    And I should see the text "arvizturo-tukorfurogep-upper"

tests/behat/features/page/page.node.create.feature

@@ -0,0 +1,73 @@
+<?php
+
+declare(strict_types = 1);
+
+namespace DrupalHu\DrupalHu\Tests\Behat\Context;
+
+use Sweetchuck\DrupalTestTraits\Core\Behat\Context\Base;
+
+class Browser extends Base {
+
+  /**
+   * @Given the :selector element is in the view
+   * @When I scroll to :selector element into view
+   *
+   * @param string $selector
+   *   CSS or XPath selector.
+   *   Examples:
+   *   - .my-class
+   *   - div
+   *   - #my-id
+   *   - css:.my-class
+   *   - css:div
+   *   - css:#my-id
+   *   - xpath://p/strong
+   *   CSS is the default locator type.
+   */
+  public function scrollToElementBySelector(string $selector): void {
+    // @todo Check that the element is exists.
+    $locator = 'css';
+    $matches = [];
+    if (preg_match('/^(?P<locator>jquery|css|xpath):/', $selector) === 1) {
+      $locator = $matches['locator'];
+      $selector = preg_replace('/^(jquery|css|xpath):/', '', $selector);
+    }
+
+    $selectorSafe = var_export($selector, TRUE);
+
+    switch ($locator) {
+      case 'jquery':
+        $script = <<<JS
+(function() {
+  jQuery($selectorSafe)[0]
+    .scrollIntoView(true);
+})()
+JS;
+        break;
+
+      case 'xpath':
+        $script = <<<JS
+(function() {
+  document
+    .evaluate($selectorSafe, document, null, XPathResult.FIRST_ORDERED_NODE_TYPE, null)
+    .singleNodeValue
+    .scrollIntoView(true);
+})()
+JS;
+        break;
+
+      default:
+        $script = <<<JS
+(function() {
+  document
+    .querySelector($selectorSafe)
+    .scrollIntoView(true);
+})()
+JS;
+        break;
+    }
+
+    $this->getSession()->executeScript($script);
+  }
+
+}