Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Builder.php Can't Correctly Find Template File for Psuedo-Patterns #22

Open
sghoweri opened this issue Oct 2, 2017 · 0 comments
Open
Labels

Comments

@sghoweri
Copy link
Collaborator

sghoweri commented Oct 2, 2017

Ex. say you have a button.twig file with the JSON data for that button.twig file living in a separate sibling folder (let's say you want to organize examples and variations of using a particular component separately).

Even though button.json is in a separate folder than button.twig, Pattern Lab still correctly picks this up and compiles everything correctly without throwing any errors.

The problem pops up when dealing with psuedo pattern variations (ex. button~large.json) which Pattern Lab currently fails to grab the correct template path for (the template path to the original button.twig file).

builder_php_ _bolt

1__gulp__open_

Good news: I've got a working fix for this that I'll be putting in shortly!

@sghoweri sghoweri added the bug label Oct 2, 2017
@sghoweri sghoweri changed the title Bug: Builder.php Can't Find Template File for Psuedo-Patterns Bug: Builder.php Can't Correctly Find Template File for Psuedo-Patterns Oct 2, 2017
sghoweri pushed a commit that referenced this issue Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant