Some cleanup and adjustments

Author: dmitry.budoragin

src/Plugin/GraphQL/DataProducer/Taxonomy/TaxonomyLoadTree.php

@@ -158,17 +158,15 @@ public function resolve(string $vid, int $parent, ?int $max_depth, ?string $lang
     $resolver = $this->entityBuffer->add('taxonomy_term', $term_ids);
 
     return new Deferred(function () use ($language, $resolver, $context, $access, $accessUser, $accessOperation) {
-      /** @var \Drupal\Core\Entity\EntityInterface[] $entities */
-      $entities = $resolver();
-
       // Add the list cache tags so that the cache entry is purged
       // whenever a new entity of this type is saved.
       $type = $this->entityTypeManager->getDefinition('taxonomy_term');
       /** @var \Drupal\Core\Entity\EntityTypeInterface $type */
       $tags = $type->getListCacheTags();
       $context->addCacheTags($tags);
 
-      if (!$entities) {
+      /** @var \Drupal\Core\Entity\EntityInterface[] $entities */
+      if (!$entities = $resolver()) {
         return [];
       }