Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The simple_example folder disappeared in the last patch #879

Closed
burgil opened this issue May 31, 2021 · 4 comments
Closed

The simple_example folder disappeared in the last patch #879

burgil opened this issue May 31, 2021 · 4 comments

Comments

@burgil
Copy link

burgil commented May 31, 2021

Issue Solved

@burgil burgil changed the title The simple_examples folder disappeared in the last patch The simple_example folder disappeared in the last patch May 31, 2021
@an-tao
Copy link
Member

an-tao commented Jun 1, 2021

It was moved to the lib/tests/integration_test/server directory.

@burgil
Copy link
Author

burgil commented Jun 1, 2021

Epic. Thanks

@marty1885
Copy link
Member

marty1885 commented Jun 1, 2021

The decision to move simple_example is because it is really not simple and not an example. It started out to be an example. yes. But ended up piling more and more "features" into that example. Furthermore, out integration test ran against that example. The simple_example became complicated and useless (provides no learning opportunity). So we decided to move it into integration test.

And we created #859 #858 to track our progress on making a new example. To allow newcomers to have a complete to learn from. Anyway #880 adds condensed examples on each feature.

This should be what you are looking for. https://github.com/an-tao/drogon/blob/30671544f725d0460cb4b6fd3b317b1c105663e2/examples/file_upload/file_upload.cc#L14-L38

@rbugajewski
Copy link
Collaborator

I understand that this was a little bit unfortunate, but in addition to what @marty1885 already explained, as far as I remember we also discussed this in our official Gitter channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants