Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file interface ,please ! #612

Closed
ghost opened this issue Oct 15, 2020 · 4 comments
Closed

Add file interface ,please ! #612

ghost opened this issue Oct 15, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Oct 15, 2020

I think we need the FS interface for microservice deployment

   By adding file interface, we can realize more file services,such as oss ,s3 ,gridfs....
   We can package the resources statically packaged in the previous section to the application with a single file

impl

@an-tao
Copy link
Member

an-tao commented Oct 15, 2020

@rbugajewski What do u think? thanks.

@rbugajewski
Copy link
Collaborator

@an-tao Any PRs are welcome 😉

I think this is (slightly) related to my comment from July regarding assets & CDN. There isn’t a lot of progress from my side yet, at least not something I’m willing to publish, so there wouldn’t be actually any conflicts if I would try to clean up & merge my code, for example, next year.

Regarding the plan for such an implementation, I think there should be one file system provider for now, then we should abstract it away into an API (what FS interface is in the chart), not the other way around, as there are functions for every storage provider that aren’t necessary mappable onto the others.

@shivshankardayal
Copy link

I do not think that it should be implemented as part of http framework.

@NOVA-ME
Copy link

NOVA-ME commented Nov 11, 2020

I think that more like a plugin for drogon, not a part of this framework.

@ghost ghost closed this as completed Jan 15, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants