Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If Drogon is made of C++ how it can be weak in Json-Sterilization #1897

Closed
allcpu opened this issue Jan 5, 2024 · 2 comments
Closed

If Drogon is made of C++ how it can be weak in Json-Sterilization #1897

allcpu opened this issue Jan 5, 2024 · 2 comments

Comments

@allcpu
Copy link

allcpu commented Jan 5, 2024

When I was comparing Drogon with other in Json-Sterilization I was not understanding how Drogon can rank less in it

image

What might be cause of it and will it be improved in feature
since Drogon is so strong in other feature then why can't it be in Json-Sterilization.

@johnpark0102
Copy link

Drogon uses jsoncpp as its JSON handler library by default.

Switching jsoncpp into nlohman or rapidjson may improve its performance, but it could break Drogon's backward compatibility since Drogon provides jsoncpp's JSON object(JSON::Value) from requests or responses.

You can specialize from_request or to_response template classes to switch Drogon's Json handler to another, but I guess benchmarks like above will not run tests that way.

Also, there's a discussion regarding Drogon 2.0 on switching Drogon's JSON library to another.

@rbugajewski
Copy link
Collaborator

@johnpark0102 Thanks for your summary.

Please continue the discussion on the already mentioned discussion (#682) where the same topic is discussed. I will close this discussion in order to reduce duplicates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants