Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hops support #39

Closed
drodil opened this issue Oct 6, 2020 · 2 comments · Fixed by #106
Closed

Add hops support #39

drodil opened this issue Oct 6, 2020 · 2 comments · Fixed by #106
Labels
enhancement New feature or request

Comments

@drodil
Copy link
Owner

drodil commented Oct 6, 2020

To be able to use IBU calculator without need to set AA for all hops it would be beneficial to have most known hops in the app. Create new struct for hop and define constant hops from https://www.brewersfriend.com/hops/ . Each hop should have name, average AA and aroma/bittering(boil)/whirlpool/dry hop (enum) usage information.

Additionally create command to find hops based on their average AA with min and max values or with their usage type.

See #23 as an example.

@mlatief
Copy link
Collaborator

mlatief commented Oct 6, 2020

This is a wip in #24, especially that AA is needed for IBU calculations

@drodil
Copy link
Owner Author

drodil commented Oct 6, 2020

@mlatief great! Please still see details in this ticket so we can use the hops also to other functionalities later on..

@drodil drodil mentioned this issue Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants