Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor beer styles, hops and yeasts #111

Open
drodil opened this issue Sep 7, 2021 · 0 comments
Open

Refactor beer styles, hops and yeasts #111

drodil opened this issue Sep 7, 2021 · 0 comments
Labels
good first issue Good for newcomers refactor Something to write again, better this time

Comments

@drodil
Copy link
Owner

drodil commented Sep 7, 2021

Hide the loading of data behind a function for example

fn get_beer_styles(criteria: Option<Criteria>) -> Vec<BeerStyle>

Move the filtering by criteria to these functions from the rustybeer-server and rustybeer-cli which both do the same thing for the list based on the criteria.
@drodil drodil added good first issue Good for newcomers refactor Something to write again, better this time labels Sep 7, 2021
drodil added a commit that referenced this issue Oct 1, 2021
@drodil
refactor: hops to not publish list of hops
fdf5c52 
Introduce get_hops functionality instead. Relates to #111
@drodil drodil mentioned this issue Oct 1, 2021
Open
drodil added a commit that referenced this issue Oct 1, 2021
@drodil
refactor: hops to not publish list of hops
18c6ada 
Introduce get_hops functionality instead. Relates to #111
drodil added a commit that referenced this issue Oct 1, 2021
@drodil
refactor: yeasts to be found with function
bf1f157 
Relates to #111
@drodil drodil mentioned this issue Oct 1, 2021
Open
drodil added a commit that referenced this issue Oct 1, 2021
@drodil
refactor: yeasts to be found with function
8fefb9b 
Relates to #111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers refactor Something to write again, better this time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drodil