Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rustybeer lib to use measurements library #109

Open
drodil opened this issue Sep 7, 2021 · 1 comment
Open

Refactor rustybeer lib to use measurements library #109

drodil opened this issue Sep 7, 2021 · 1 comment
Labels
refactor Something to write again, better this time

Comments

@drodil
Copy link
Owner

drodil commented Sep 7, 2021 •
edited
Loading

Refactor rustybeer calculators to use measurements structs. This will standardize the API to accept input in any unit and also to return structs that can be converted to the users desired unit. At least the following calculators could take this into use:

  • Calorie counter
  • Alcohol volume weight
  • Diluting
  • IBU
  • Bottles calculator
  • Priming

At the moment the functions in these calculators take mixed units (from fahrenheit to grams to fluid ounces etc.)
@drodil drodil mentioned this issue Sep 7, 2021
Open
drodil added a commit that referenced this issue Sep 7, 2021
@drodil
chore: merge util and rustybeer libraries
2bba6dc 
this is to make handling conversions more easier for #109
drodil added a commit that referenced this issue Sep 7, 2021
@drodil
chore: merge util and rustybeer libraries
9cd9ff7 
this is to make handling conversions more easier for #109
drodil added a commit that referenced this issue Sep 7, 2021
@drodil
chore: merge util and rustybeer libraries
057ef81 
this is to make handling conversions more easier for #109
@drodil drodil mentioned this issue Sep 7, 2021
Merged
@drodil drodil added the refactor Something to write again, better this time label Sep 7, 2021
This was referenced Sep 14, 2021
Merged
Merged
@drodil
Copy link
Owner Author

drodil commented Sep 14, 2021

Still to do:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor Something to write again, better this time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drodil