Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REQUEST] - Refactor middleware #41

Open
williycole opened this issue Apr 28, 2023 · 0 comments
Open

[REQUEST] - Refactor middleware #41

williycole opened this issue Apr 28, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@williycole
Copy link
Collaborator

williycole commented Apr 28, 2023 •
edited
Loading

Summary

Refactor middleware to move the redundant code to a more general middleware and then have separate functions deal with a dms VS a channel

Basic Example

Breaking out crud ops from middleware into their own functions.

Drawbacks

  • potentially will have to rewrite some middleware tests but could likely reuse some logic.

Unresolved questions

No response
@williycole williycole added question Further information is requested enhancement New feature or request and removed question Further information is requested labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williycole