Skip to content

Couldn't find 'errors' array into Mailchimp class #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
teolaz opened this issue Mar 19, 2018 · 4 comments
Open

Couldn't find 'errors' array into Mailchimp class #235

teolaz opened this issue Mar 19, 2018 · 4 comments

Comments

@teolaz
Copy link

teolaz commented Mar 19, 2018

Hi there,
i just realized that inspecting your class you arent' checking the errors json encoded array from the response body of Mailchimp servers, if a 4xx error occourred, it should be interesting to have a getErrorsArray method on class to parse each error...
Do you think that will be possible?
Clearly, the last_error variable is populated with the status and detail of the formattedResponse, but that seems not to be enough for complete controlling the errors....

image

Thanks

@drewm
Copy link
Owner

drewm commented Mar 19, 2018

Yes, I'd be interested to see a PR for that.

@teolaz
Copy link
Author

teolaz commented Mar 19, 2018

@drewm no time to waiste ah? :D will see if i can help...

@teolaz teolaz mentioned this issue Mar 19, 2018
@teolaz
Copy link
Author

teolaz commented Mar 19, 2018

@drewm please check the PR here #236

@edalzell
Copy link

edalzell commented Sep 6, 2019

Would be great if this could get merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants