Skip to content

Commit b5f5256

Browse files
dvyukovmemfrob
authored and
memfrob
committed
tsan: fix latent race size bug in test
The test contains a race in read/write syscalls. The size of reported race depends on how the accessed memory range split into granules inside of tsan runtime. The test used to report access of size 8, because presumably the buffer ended up being aligned to 8 bytes. But after some unrelated changes this test started to report accesses of size 1 (presumably .data layout changed), which makes the test fail. Guarantee alignment of the buf object explicitly. Reviewed By: vitalybuka, melver Differential Revision: https://reviews.llvm.org/D107131
1 parent 0f45bcd commit b5f5256

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

compiler-rt/test/tsan/Linux/syscall.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
#include <sys/wait.h>
77

88
int pipefd[2];
9-
char buf[10];
9+
unsigned long long buf[2];
1010

1111
static void *thr(void *p) {
1212
barrier_wait(&barrier);

0 commit comments

Comments
 (0)