Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move bumpup logic out of FindInternal #4775

Open
romange opened this issue Mar 16, 2025 · 0 comments
Open

Move bumpup logic out of FindInternal #4775

romange opened this issue Mar 16, 2025 · 0 comments
Assignees
@mkaruza

Comments

@romange
Copy link
Collaborator

romange commented Mar 16, 2025

We should try moving it into DbSlice::OnCbFinish.
we do not need precise logic for bump ups and we can use fetched_items_ as a set of fingerprints that needs
to be bumped up in OnCbFinish

This will greatly simplify FindInternal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaruza mkaruza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romange @mkaruza