Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object_used_memory and memory type counters overflow #4773

Closed
romange opened this issue Mar 15, 2025 · 0 comments · Fixed by #4774
Closed

object_used_memory and memory type counters overflow #4773

romange opened this issue Mar 15, 2025 · 0 comments · Fixed by #4774
Assignees
@romange
Milestone
v1.28

Comments

@romange
Copy link
Collaborator

romange commented Mar 15, 2025

Sometimes Dragonfly shows object_used_memory and list related counters as overflown (high 64 bit numbers)
@romange romange self-assigned this Mar 15, 2025
romange added a commit that referenced this issue Mar 15, 2025
@romange
fix: proper memory accounting for objects loaded via streaming
d13ab7b 
The bug: during the loading when appending to the existing object,
ItAndUpdater scope did not account for the appended data, and as a result
`object_used_memory` and its variation did not account for streamed objects.

The fix: to extend the scope of the ItAndUpdater object to cover appends.
Added a sanity DCHECK that ensures that object_used_memory is at least as the memory used
by a single object. This dcheck fails pre-fix.

Fixes #4773

Signed-off-by: Roman Gershman <[email protected]>
@romange romange mentioned this issue Mar 15, 2025
Merged
romange added a commit that referenced this issue Mar 16, 2025
@romange
fix: proper memory accounting for objects loaded via streaming
f9bb158 
The bug: during the loading when appending to the existing object,
ItAndUpdater scope did not account for the appended data, and as a result
`object_used_memory` and its variation did not account for streamed objects.

The fix: to extend the scope of the ItAndUpdater object to cover appends.
Added a sanity DCHECK that ensures that object_used_memory is at least as the memory used
by a single object. This dcheck fails pre-fix.

Fixes #4773

Signed-off-by: Roman Gershman <[email protected]>
@romange romange added this to the v1.28 milestone Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romange romange

Labels
None yet
Projects
None yet
Milestone
v1.28
Development

Successfully merging a pull request may close this issue.

fix: proper memory accounting for objects loaded via streaming dragonflydb/dragonfly
1 participant
@romange