fix: address comments

Author: BorysTheDev

src/server/cluster/cluster_defs.h

@@ -98,7 +98,7 @@ enum class NodeHealth : std::uint8_t { FAIL, LOADING, ONLINE, HIDDEN };
 std::string_view ToString(NodeHealth nh);
 
 struct ClusterExtendedNodeInfo : ClusterNodeInfo {
-  NodeHealth health = NodeHealth::FAIL;
+  NodeHealth health = NodeHealth::ONLINE;
 };
 
 struct MigrationInfo {

src/server/cluster/cluster_family.cc

@@ -307,7 +307,7 @@ void ClusterNodesImpl(const ClusterShardInfos& config, string_view my_id,
 
   string result;
 
-  auto WriteNode = [&](const ClusterNodeInfo& node, string_view role, string_view master_id,
+  auto WriteNode = [&](const ClusterExtendedNodeInfo& node, string_view role, string_view master_id,
                        const SlotRanges& ranges) {
     absl::StrAppend(&result, node.id, " ");
 
@@ -320,7 +320,8 @@ void ClusterNodesImpl(const ClusterShardInfos& config, string_view my_id,
 
     absl::StrAppend(&result, master_id, " ");
 
-    absl::StrAppend(&result, "0 0 0 connected");
+    absl::StrAppend(&result,
+                    node.health != NodeHealth::FAIL ? "0 0 0 connected" : "0 0 0 disconnected");
 
     for (const auto& range : ranges) {
       absl::StrAppend(&result, " ", range.start);

src/server/cluster/cluster_family_test.cc

@@ -432,12 +432,12 @@ TEST_F(ClusterFamilyTest, ClusterConfigFullMultipleInstances) {
                                             "qwerty1")))))));
 
   EXPECT_THAT(Run({"cluster", "nodes"}),
-              "abcd1234 10.0.0.1:7000@7000 master - 0 0 0 connected 0-10000\n"
+              "abcd1234 10.0.0.1:7000@7000 master - 0 0 0 disconnected 0-10000\n"
               "wxyz 10.0.0.10:8000@8000 slave abcd1234 0 0 0 connected\n"
               "efgh7890 10.0.0.2:7001@7001 master - 0 0 0 connected 10001-16383\n"
               "qwerty 10.0.0.11:8001@8001 slave efgh7890 0 0 0 connected\n"
               "qwerty1 10.0.0.12:8002@8002 slave efgh7890 0 0 0 connected\n"
-              "qwerty2 10.0.0.13:8003@8003 slave efgh7890 0 0 0 connected\n");
+              "qwerty2 10.0.0.13:8003@8003 slave efgh7890 0 0 0 disconnected\n");
 
   absl::InsecureBitGen eng;
   while (true) {