Skip to content

Commit 370315e

Browse files
committed
Merge branch 'master' of github.com:itinance/react-native-fs
2 parents 49eed8a + 34551d0 commit 370315e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

README.md

+6-5
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,8 @@ var files = [
265265
}
266266
];
267267

268-
var uploadBegin = (response) => {
268+
var upload
269+
= (response) => {
269270
var jobId = response.jobId;
270271
console.log('UPLOAD HAS BEGUN! JobId: ' + jobId);
271272
};
@@ -335,8 +336,8 @@ type ReadDirItem = {
335336
name: string; // The name of the item
336337
path: string; // The absolute path to the item
337338
size: string; // Size in bytes
338-
isFile: () => boolean; // Is the file just a file?
339-
isDirectory: () => boolean; // Is the file a directory?
339+
isFile: () => boolean; // Is the item just a file?
340+
isDirectory: () => boolean; // Is the item a directory?
340341
};
341342
```
342343

@@ -375,7 +376,7 @@ type StatResult = {
375376
path: // The same as filepath argument
376377
ctime: date; // The creation date of the file
377378
mtime: date; // The last modified date of the file
378-
size: string; // Size in bytes
379+
size: number; // Size in bytes
379380
mode: number; // UNIX file mode
380381
originalFilepath: string; // ANDROID: In case of content uri this is the pointed file path, otherwise is the same as path
381382
isFile: () => boolean; // Is the file just a file?
@@ -558,7 +559,7 @@ type DownloadFileOptions = {
558559
cacheable?: boolean; // Whether the download can be stored in the shared NSURLCache (iOS only, defaults to true)
559560
progressInterval?: number;
560561
progressDivider?: number;
561-
begin?: (res: DownloadBeginCallbackResult) => void;
562+
begin?: (res: DownloadBeginCallbackResult) => void; // Note: it is required when progress prop provided
562563
progress?: (res: DownloadProgressCallbackResult) => void;
563564
resumable?: () => void; // only supported on iOS yet
564565
connectionTimeout?: number // only supported on Android yet

0 commit comments

Comments
 (0)