Skip to content

Commit 2b27f14

Browse files
authored
PR feedback and adding comments
1 parent bfd70fb commit 2b27f14

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

eng/Tools.props

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
<Project>
22

33
<PropertyGroup>
4-
<RuntimeIdentifier Condition="'$(Platform)' == ''">win-x86</RuntimeIdentifier>
5-
<RuntimeIdentifier Condition="'$(Platform)' != ''">win-$(Platform)</RuntimeIdentifier>
4+
<_RuntimeIdentifier Condition="'$(Platform)' == ''">win-x86</_RuntimeIdentifier>
5+
<_RuntimeIdentifier Condition="'$(Platform)' != ''">win-$(Platform)</_RuntimeIdentifier>
66
</PropertyGroup>
77

88
<!-- Pre-download vcxproj dependencies as vcxprojs in this repo don't support NuGet package download. -->
99
<ItemGroup>
1010
<PackageDownload Include="Microsoft.NETCore.App.Ref" Version="[$(MicrosoftNETCoreAppRefVersion)]" Condition="'$(MicrosoftNETCoreAppRefVersion)' != ''" />
11-
<PackageDownload Include="Microsoft.NETCore.App.Runtime.$(RuntimeIdentifier)" Version="[$(MicrosoftNETCoreAppRuntimewinx64Version)]" Condition="'$(MicrosoftNETCoreAppRuntimewinx64Version)' != ''" />
12-
<PackageDownload Include="Microsoft.NETCore.App.Host.$(RuntimeIdentifier)" Version="[$(MicrosoftNETCoreAppRuntimewinx64Version)]" Condition="'$(MicrosoftNETCoreAppRuntimewinx64Version)' != ''" />
11+
<PackageDownload Include="Microsoft.NETCore.App.Runtime.$(_RuntimeIdentifier)" Version="[$(MicrosoftNETCoreAppRuntimewinx64Version)]" Condition="'$(MicrosoftNETCoreAppRuntimewinx64Version)' != ''" />
12+
<PackageDownload Include="Microsoft.NETCore.App.Host.$(_RuntimeIdentifier)" Version="[$(MicrosoftNETCoreAppRuntimewinx64Version)]" Condition="'$(MicrosoftNETCoreAppRuntimewinx64Version)' != ''" />
1313
</ItemGroup>
1414

1515
</Project>

eng/WpfArcadeSdk/tools/RuntimeFrameworkReference.targets

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
<KnownFrameworkReference Remove="Microsoft.AspNetCore.App" />
2020
</ItemGroup>
2121

22+
<!-- The below logic intentionally doesn't consider multiple .NETCoreApp TFMs as that isn't necessary at this point. -->
2223
<PropertyGroup>
2324
<UseOOBNETCoreAppTargetingPack Condition="'$(UseOOBNETCoreAppTargetingPack)' == ''">true</UseOOBNETCoreAppTargetingPack>
2425
<UseOOBNETCoreAppRuntimePack Condition="'$(UseOOBNETCoreAppRuntimePack)' == ''">true</UseOOBNETCoreAppRuntimePack>
@@ -51,7 +52,8 @@
5152
</ItemGroup>
5253

5354
<!-- Update paths for resolved packs which is necessary when the packs couldn't be resolved.
54-
This happens when package download is disabled and the package isn't available in the SDK's packs folder. -->
55+
This happens when package download is disabled and the package isn't available in the SDK's packs folder.
56+
This entire target can be removed when vcxproj's NuGet support gets enabled. -->
5557
<Target Name="UpdateOOBPacks"
5658
Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp'"
5759
AfterTargets="ResolveFrameworkReferences">

0 commit comments

Comments
 (0)